Add eccentric weight increase option to Old School mode

[9thLevelSoftware]

Enhancement Request: Eccentric Weight Increase for Old School Mode

Reporter: evulnater (Discord user 281238440131952650)
Type: Enhancement / Feature Request
Repo: Mobile (project-phoenix-mp)
Source: Discord #feature-requests thread 1530248964660531271

---

Summary

Add an option in Old School mode where the weight during the eccentric phase is increased by a certain percentage, just like Echo mode.

Request Details

The user wants a new behavior for Old School mode where the eccentric (lowering) phase of each rep has a higher weight than the concentric (lifting) phase. This is similar to how Echo mode already handles eccentric overload, but applied to Old School mode.

Original Discord Request

Feature request for an option in Old School mode where the weight during the eccentric phase is increased by a certain percentage, just like Echo mode

Additional Context

The reporter noted that the original issue body was incorrectly copied from a previous thread. This is the correct content for this enhancement request.

---

This issue was auto-created from a Discord feature request.

[9thLevelSoftware]

Additional info from Discord thread:

<@1502654170031849644>, while you titled this thread's github page correctly, it seems that you copied the content of the previous thread's github page almost entirely, which is incorrect

— added by ticket bot

[9thLevelSoftware]

Feasibility Assessment

Recommendation: ACCEPT

This enhancement is feasible with moderate effort (2–3 weeks). All infrastructure already exists:

• EccentricLoad enum supports 0–150% (same as Echo mode)
• eccentricLoadPercentage field already exists in profile preferences documents
• Echo mode's 0x4E BLE packet with eccentricOverload is proven on hardware
• Profile sync (mobile ↔ portal) already handles the field

Approach: When eccentric load > 100% is selected for Old School mode, dispatch the Echo packet format (0x4E) with the eccentric overload percentage and Old School-appropriate velocity/timing defaults. This reuses the proven Echo eccentric mechanism without requiring firmware changes.

Key work:

1. Remove the isEchoMode gate on eccentric load in the session engine
2. Show eccentric load controls in JustLiftScreen/SetReadyScreen for Old School mode
3. Dispatch 0x4E packet when Old School exercises have eccentric load > 100%
4. Hardware validation that firmware accepts 0x4E with Old School velocity parameters

Risk: Medium — requires on-device testing to confirm firmware accepts the Echo packet format with non-Echo velocity parameters. CSV export and gamification tests will also need updating.

Full assessment artifact: phoenix-enhancements/issue-674-1530248964660531271/feasibility.md

[9thLevelSoftware]

Architecture Design

Status: Complete

Architecture artifact written: architecture.md

Key decisions:

1. BLE dispatch: When Old School eccentric load > 100%, dispatch the 0x4E Echo control packet (proven eccentric overload mechanism). When <= 100%, use the normal 0x04 Old School activation frame (no behavior change).
2. Fixed EchoLevel.HARDER for Old School eccentric dispatch — widest concentric timing window (1.25s @ 40mm/s) to minimize concentric interference. EchoLevel selector stays Echo-only.
3. isEchoMode stays false for Old School — preserves PR tracking, gamification, rep counting, and UI behavior. Only BLE dispatch and deload/stall handling are modified.
4. Zero warmupReps for Old School 0x4E dispatch — Old School doesn't use firmware-managed warmup reps.
5. No schema migration, no portal/backend changes, no validator changes — all infrastructure (EccentricLoad enum, DB columns, sync DTOs, profile prefs) already exists.

UI changes:

• Eccentric load selector becomes visible for Old School mode in JustLiftScreen, SetReadyScreen, ExerciseEditBottomSheet, and RoutineOverviewScreen
• EchoLevel selector remains Echo-only

Engine changes:

• Dispatch 0x4E when eccentricLoad.percentage > 100 for any mode
• Remove isEchoMode gate on defaults save (lines 1846, 1886) — save actual eccentric load for all modes
• Add hasEccentricOverload to deload skip condition (line 433) — prevents false stall detection from 0x4E timing events

Files to change: 10 (6 source + 4 test files)

• No changes needed to BlePacketFactory, WorkoutCommandValidator, ProfilePreferencesValidator, SchemaManifest, PortalSyncDtos, BackupModels, CsvExporter, GamificationManager, or EchoParams

Primary risk: Hardware validation

The 0x4E packet includes concentric phase parameters that may change how Old School's concentric phase feels. A hardware validation test plan (8 tests covering different eccentric loads, EchoLevels, Just Lift, routines, and AMRAP) is documented. Three fallback plans are defined if concentric behavior is unacceptable.

Non-goals:

• No portal UI changes
• No changes to Echo mode behavior
• No changes to other modes (Pump, TUT, TUTBeast, EccentricOnly)
• No new EccentricLoad enum values
• No CSV column additions
• No firmware changes

Full artifact: phoenix-enhancements/issue-674-1530248964660531271/architecture.md

[9thLevelSoftware]

Integration Model Complete

The integration model has been verified against the live source code (commit 7935b37). All file locations, line numbers, and data structures referenced in the architecture document have been confirmed.

Summary:

• 6 source files to change (ActiveSessionEngine dispatch + defaults + deload, Models.kt computed property, JustLiftScreen LaunchedEffect)
• 4 UI files to change (JustLiftScreen, SetReadyScreen, ExerciseEditBottomSheet, RoutineOverviewScreen)
• 4 test files to add tests to (BlePacketFactoryTest, WorkoutCommandValidatorTest, WorkoutParametersTest, CsvExporterTest)
• Zero schema migration — all DB columns, portal sync DTOs, backup models, and validators already support eccentric load > 100% for any mode
• Zero portal/backend changes

Two corrections to the architecture document:

1. warmupReps must be 3, not 0 (ADR-5 correction): Issue [Bug]: Warm-up Sets stop registering 3 reps short for each warm-up set #411 proved that setting warmupReps=0 causes the machine to dump the load 3 reps early because the firmware always consumes the first 3 reps for ROM/cable calibration. The engine consistently uses Constants.DEFAULT_WARMUP_REPS = 3 for all cable exercises. The 0x4E dispatch for Old School must use warmupReps=3, not 0.

2. JustLiftScreen Card requires structural split: The eccentric load dropdown and EchoLevel selector are inside a shared Card (lines 584-696). A simple guard change would incorrectly show the EchoLevel selector for Old School. The Card must be split: eccentric dropdown visible for isEchoMode || isOldSchool, EchoLevel selector visible only for isEchoMode.

Integration seams identified:

• SetReadyState.eccentricLoadPercent may not be populated for Old School exercises (ViewModel initialization needs verification)
• RoutineOverviewScreen card component display logic may need updating to show eccentric load > 100% regardless of mode

Next stage: Prototype/UI design gate

[9thLevelSoftware]

In-App Prototype — Old School Eccentric Load\n\nThe proposed UI was rendered in the actual Phoenix app running in the iOS simulator with the Phantom fixture.\n\n\n\nScreen: Just Lift\nPrototype state: Old School selected with Eccentric Load set to 130%\nDesign intent: Keep the eccentric-load selector visible for Old School while keeping Echo-only level controls hidden.\nNote: Visual mockup only; the displayed 130% value is hardcoded for this prototype and will be wired to the existing workout defaults/state in implementation.

[9thLevelSoftware]

In-App Prototype — Old School Eccentric Load

The proposed UI was rendered in the actual Phoenix app running in the iOS simulator with the just-lift-connected Phantom fixture.

Screen: Just Lift
Prototype state: Old School selected with Eccentric Load set to 130%
Design intent: Keep the eccentric-load selector visible for Old School while keeping Echo-only level controls hidden.
Note: Visual mockup only; the displayed 130% value is hardcoded for this prototype and will be wired to the existing workout defaults/state in implementation.

[9thLevelSoftware]

Signoff requested — Old School eccentric overload

The enhancement design is ready for your approval before implementation.

Proposed behavior

• Old School mode will expose the existing Eccentric Load control. Values above 100% increase resistance only while lowering; the standard 100% setting preserves today's behavior.
• The Echo Level controls remain exclusive to Echo mode, so Old School keeps its existing, simpler workflow.
• Old School sessions with eccentric load above 100% will use the existing machine 0x4E control packet with a fixed HARDER profile and the established three-rep calibration buffer. Old School at 100% continues to use its current 0x04 activation packet.
• The feature reuses existing workout, sync, backup, and database fields: no schema migration, portal work, or firmware change is proposed.

Reviewed design evidence

• Feasibility: accepted; the existing eccentric-load and packet infrastructure can support this scope.
• Integration review identified and incorporated two safeguards: use three calibration reps (not zero) and split the UI so the Old School eccentric selector does not reveal Echo-only controls.
• In-app prototype: Old School with a 130% Eccentric Load control

Important validation boundary

Implementation will still require connected-machine validation before release: we need to confirm that the 0x4E packet provides the intended eccentric overload while preserving acceptable Old School concentric feel, rep counting, and AMRAP/routine behavior. The design includes fallback paths if that hardware validation fails.

Please approve the scope by replying approved, looks good, or go ahead, or by adding a 👍 / +1 / thumbs-up reaction to this comment or the Discord signoff message. If you want changes, reply with what you would like adjusted.

[9thLevelSoftware]

Implementation Plan

The implementation spec is complete and signed off. Here's the summary:

Approach

Reuse the proven Echo 0x4E BLE packet for Old School mode when eccentric load > 100%. When eccentric load ≤ 100%, the normal Old School 0x04 packet is used (no behavior change). isEchoMode stays false — PR tracking, gamification, and Old School app behavior are preserved.

Key Design Decisions

• Fixed EchoLevel.HARDER for Old School 0x4E dispatch (widest concentric timing window)
• warmupReps = 3 (Constants.DEFAULT_WARMUP_REPS) — supersedes architecture ADR-5, proven by Issue [Bug]: Warm-up Sets stop registering 3 reps short for each warm-up set #411 firmware calibration fix
• isEchoMode remains false for Old School — preserves all app-side Old School behavior
• No database migration, no portal changes, no Echo mode regression

Implementation Packets (8 bounded packets)

1. Data Model — Add hasEccentricOverload computed property to WorkoutParameters
2. Engine — BLE dispatch decision, defaults save gate removal, deload stall skip
3. JustLiftScreen — LaunchedEffect fix + Card structural split (eccentric dropdown vs EchoLevel)
4. SetReadyScreen — Guard split (eccentric slider visible for Old School, EchoLevel stays Echo-only)
5. ExerciseEditBottomSheet — Guard split (EccentricLoadSelector visible for Old School)
6. RoutineOverviewScreen — Display eccentric load when > 100% regardless of mode
7. ViewModel Seam — Verify SetReadyState initialization for Old School exercises
8. Tests — 11 test cases (4 model + 2 BLE + 1 CSV + 4 integration)

Files to Change

• 6 source files: Models.kt, ActiveSessionEngine.kt, JustLiftScreen.kt, SetReadyScreen.kt, ExerciseEditBottomSheet.kt, RoutineOverviewScreen.kt
• 4 test files: WorkoutParametersTest.kt, BlePacketFactoryTest.kt, WorkoutCommandValidatorTest.kt, CsvExporterTest.kt + ActiveSessionEngineIntegrationTest.kt

Non-Goals

• No portal UI changes
• No new EccentricLoad enum values
• No Echo mode behavior changes
• No database migration
• No firmware changes

Risk: Hardware Validation Required

The 0x4E packet's concentric phase parameters may change Old School's concentric feel. Hardware validation (8-test matrix) is required before production release. Fallback plans documented if concentric behavior is unacceptable.

[9thLevelSoftware]

Implementation complete. PR #680 opened at #680

Summary of changes:

• 7 production source files changed (Models.kt, ActiveSessionEngine.kt, JustLiftScreen.kt, SetReadyScreen.kt, ExerciseEditBottomSheet.kt, RoutineOverviewScreen.kt, RoutineFlowManager.kt)
• 3 test files with 9 new unit tests
• Kotlin compilation verified clean
• Zero schema migration, zero portal changes, zero Echo mode regression

Key decisions:

• warmupReps=3 (Issue [Bug]: Warm-up Sets stop registering 3 reps short for each warm-up set #411 correction, not 0 as originally architected)
• EchoLevel.HARDER fixed for Old School dispatch (widest concentric window)
• JustLiftScreen Card split to separate eccentric dropdown from EchoLevel selector

[9thLevelSoftware]

Implementation complete — PR #683 is open: #683

Changes: 7 source files + 1 test file (4 new tests). Build verified (compileKotlinIosArm64 SUCCESS), all tests pass (iosSimulatorArm64Test SUCCESS).

Key implementation details:

• Dispatches 0x4E Echo packet when Old School eccentric load > 100%
• EchoLevel.HARDER + warmupReps=3 (Constants.DEFAULT_WARMUP_REPS)
• isEchoMode stays false — PR/gamification/UI preserved
• Zero schema migration, zero portal changes
• Eccentric load UI visible in JustLiftScreen, SetReadyScreen, ExerciseEditBottomSheet, RoutineOverviewScreen

[9thLevelSoftware]

Additional info from Discord thread:

That looks and sounds perfect, A++! Approved for sure

— added by ticket bot