Error in worker.sh

[tbertels]

See https://github.com/AppImage/appimage.github.io/actions/runs/20827433205/job/59832372241?pr=3624

   # License
  AS_LICENSE=""
+ AS_LICENSE=
  DT_LICENSE=""
+ DT_LICENSE=
  if [ -f database/$INPUTBASENAME/*appdata.xml ] ; then
    AS_LICENSE=$(cat database/$INPUTBASENAME/*appdata.xml | xmlstarlet sel -t -m "/component/project_license" -v .) || true
  fi
+ '[' -f 'database/mpc-qt/*appdata.xml' ']'
  DT_LICENSE=$(grep -r "X-AppImage-Payload-License=.*" database/$INPUTBASENAME/*.desktop | cut -d '=' -f 2)
++ grep -r 'X-AppImage-Payload-License=.*' database/mpc-qt/io.github.mpc_qt.mpc-qt.desktop
++ cut -d = -f 2
+ DT_LICENSE=
worker.sh exited with a non-zero code: 1
Error: Process completed with exit code 1.

Code:

appimage.github.io/code/worker.sh

Lines 459 to 470 in 260f0fd

	# License
	AS_LICENSE=""
	DT_LICENSE=""
	if [ -f database/$INPUTBASENAME/*appdata.xml ] ; then
	AS_LICENSE=$(cat database/$INPUTBASENAME/*appdata.xml | xmlstarlet sel -t -m "/component/project_license" -v .) || true
	fi
	DT_LICENSE=$(grep -r "X-AppImage-Payload-License=.*" database/$INPUTBASENAME/*.desktop | cut -d '=' -f 2)
	if [ x"$AS_LICENSE" != x"" ] ; then
	echo "license: $AS_LICENSE" >> apps/$INPUTBASENAME.md
	elif [ x"$DT_LICENSE" != x"" ] ; then
	echo "license: $DT_LICENSE" >> apps/$INPUTBASENAME.md
	fi

[shpala]

Note to the maintainers:
Previously the worker.sh script was looking for one of the license variables using grep, but couple months ago "set -o pipefail" was added to the beginning of it.
So now any grep command that returns an empty string will possibly cause worker.sh to exit with error.
Even if you define both AS_LICENSE and DT_LICENSE, your build will fail, because it will try to grep and set BOTH GH_USER and OBS_USER from the data file. Which obviously won't work.
The specific issue is that every $(grep | cut) command that returns an empty string will fail the execution because of pipefail on line 5.
So even though there's a specific check of whether GH_USER is empty before checking OBS_USER, the script will fail on line 495 because there's no OBS URL on AppImage PRs that are linked to github.

appimage.github.io/code/worker.sh

Lines 493 to 511 in 260f0fd

	GH_USER=$(grep "^https://github.com.*" data/$INPUTBASENAME | cut -d '/' -f 4 )
	GH_REPO=$(grep "^https://github.com.*" data/$INPUTBASENAME | cut -d '/' -f 5 )
	OBS_USER=$(grep "^http.*://download.opensuse.org/repositories/home:/" data/$INPUTBASENAME | cut -d "/" -f 6 | sed -e 's|:||g')
	# BB_USER=$(grep "^https://bitbucket.org.*" data/$INPUTBASENAME | cut -d '/' -f 4 )
	# BB_REPO=$(grep "^https://bitbucket.org.*" data/$INPUTBASENAME | cut -d '/' -f 5 )
	if [ x"$GH_USER" == x"" ] ; then
	GH_USER=$(grep "^https://api.github.com.*" data/$INPUTBASENAME | cut -d '/' -f 5 )
	GH_REPO=$(grep "^https://api.github.com.*" data/$INPUTBASENAME | cut -d '/' -f 6 )
	fi
	if [ x"$GH_USER" != x"" ] ; then
	echo " - name: $GH_USER" >> apps/$INPUTBASENAME.md
	echo " url: https://github.com/$GH_USER" >> apps/$INPUTBASENAME.md
	elif [ x"$OBS_USER" != x"" ] ; then
	echo " - name: $OBS_USER" >> apps/$INPUTBASENAME.md
	echo " url: https://build.opensuse.org/user/show/$OBS_USER" >> apps/$INPUTBASENAME.md
	# elif [ x"$BB_USER" != x"" ] ; then
	# echo " - name: $BB_USER" >> apps/$INPUTBASENAME.md
	# echo " url: https://bitbucket.org/$BB_USER" >> apps/$INPUTBASENAME.md
	fi

I've been able to create a workaround for that, by adding a second bogus OBS link with my real github username after the real github link (see #3653).
This workaround worked, because worker.sh finds the first appimage url because it matches the regex, but regex that looks for the OBS_USER looks for a line that starts with the URL of the opensuse download server, this works because the bogus opensuse url is in a new line, so the grep succeeds.
Please fix the worker.sh to maybe only require one of the services, same as with the license type.

[shpala]

@tbertels Add "X-AppImage-Payload-License=" to your database/mpc-qt/io.github.mpc_qt.mpc-qt.desktop file to pass that specific test.
Then it will fail on empty OBS_USER. See my PR #3653 on how to easily work around that.

[tbertels]

Thanks for the help!

[lordmulder]

Probably related to: #3678

[probonopd]

These fields are not meant to be mandatory. So I'd appreciate a pull request that would make them optional. Thanks!

[tbertels]

These fields are not meant to be mandatory. So I'd appreciate a pull request that would make them optional. Thanks!

What about #3655?