From ce589372b5216d923a6acecccbc5c268f1e503fb Mon Sep 17 00:00:00 2001 From: sid597 Date: Sun, 5 Jul 2026 23:51:06 +0530 Subject: [PATCH 1/2] ENG-1965: Rename Template-Block-props buffer block to Template (editing) Not plain "Template" because getSubTree({parentUid: node.type, key: "Template"}) in NodeConfig.tsx and DiscourseNodeSuggestiveRules.tsx text-matches children of the same parent the buffer is created under, and auto-creates on miss - an exact "Template" buffer would collide with the legacy template block lookup. --- .../src/components/settings/components/EphemeralBlocksPanel.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/roam/src/components/settings/components/EphemeralBlocksPanel.tsx b/apps/roam/src/components/settings/components/EphemeralBlocksPanel.tsx index b709d3250..fd5bde34a 100644 --- a/apps/roam/src/components/settings/components/EphemeralBlocksPanel.tsx +++ b/apps/roam/src/components/settings/components/EphemeralBlocksPanel.tsx @@ -14,7 +14,7 @@ import { import type { DiscourseNodeBaseProps } from "./BlockPropSettingPanels"; const DEBOUNCE_MS = 250; -const TEMPLATE_BUFFER_TEXT = "Template-Block-props"; +const TEMPLATE_BUFFER_TEXT = "Template (editing)"; type DualWriteBlocksPanelProps = DiscourseNodeBaseProps & { uid: string; From 18a550976e31493d49fd951547083bef4c60f817 Mon Sep 17 00:00:00 2001 From: sid597 Date: Mon, 6 Jul 2026 14:21:48 +0530 Subject: [PATCH 2/2] ENG-1965: Use plain Template for the buffer block text The (editing) suffix guarded against getSubTree(key: "Template") matching the buffer, but getBasicTreeByParentUid returns children order-sorted and the legacy Template block is auto-created at order 0 before the buffer (order last) can exist, so the lookup always resolves to the legacy block. Plain Template is what the ticket asks for and reads correctly under the Template tab. --- .../src/components/settings/components/EphemeralBlocksPanel.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/roam/src/components/settings/components/EphemeralBlocksPanel.tsx b/apps/roam/src/components/settings/components/EphemeralBlocksPanel.tsx index fd5bde34a..3e0fd8aa6 100644 --- a/apps/roam/src/components/settings/components/EphemeralBlocksPanel.tsx +++ b/apps/roam/src/components/settings/components/EphemeralBlocksPanel.tsx @@ -14,7 +14,7 @@ import { import type { DiscourseNodeBaseProps } from "./BlockPropSettingPanels"; const DEBOUNCE_MS = 250; -const TEMPLATE_BUFFER_TEXT = "Template (editing)"; +const TEMPLATE_BUFFER_TEXT = "Template"; type DualWriteBlocksPanelProps = DiscourseNodeBaseProps & { uid: string;