From c7e6653fad57708194d2b03d0952f4b2862369e6 Mon Sep 17 00:00:00 2001 From: Florian Pfaff <6773539+FlorianPfaff@users.noreply.github.com> Date: Thu, 2 Jul 2026 10:25:00 +0200 Subject: [PATCH 1/2] Validate evidence support type before set lookup --- src/pyrecest/diagnostics.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/pyrecest/diagnostics.py b/src/pyrecest/diagnostics.py index bcc53bf92..73d7b7672 100644 --- a/src/pyrecest/diagnostics.py +++ b/src/pyrecest/diagnostics.py @@ -243,7 +243,10 @@ class EvidenceSupport: diagnostics: dict[str, Any] = field(default_factory=dict) def __post_init__(self) -> None: - if self.support_type not in _EVIDENCE_SUPPORT_TYPES: + if ( + not isinstance(self.support_type, str) + or self.support_type not in _EVIDENCE_SUPPORT_TYPES + ): raise ValueError( f"unsupported evidence support type {self.support_type!r}; " f"expected one of {sorted(_EVIDENCE_SUPPORT_TYPES)}" From 9a3b275a2a3c37fa450482ecd40af65f6b6d3e72 Mon Sep 17 00:00:00 2001 From: Florian Pfaff <6773539+FlorianPfaff@users.noreply.github.com> Date: Thu, 2 Jul 2026 10:27:43 +0200 Subject: [PATCH 2/2] Add EvidenceSupport list value regression test --- tests/test_evidence_support_invalid_values.py | 10 ++++++++++ 1 file changed, 10 insertions(+) create mode 100644 tests/test_evidence_support_invalid_values.py diff --git a/tests/test_evidence_support_invalid_values.py b/tests/test_evidence_support_invalid_values.py new file mode 100644 index 000000000..ff375473a --- /dev/null +++ b/tests/test_evidence_support_invalid_values.py @@ -0,0 +1,10 @@ +import pytest + +from pyrecest.diagnostics import EvidenceSupport + + +def test_evidence_support_rejects_list_value() -> None: + bad_value = list(("unknown",)) + + with pytest.raises(ValueError, match="unsupported evidence support type"): + EvidenceSupport(bad_value)