From 24ffe16177c75f54255c4122397decf317398931 Mon Sep 17 00:00:00 2001 From: Markus Opolka Date: Mon, 13 Jul 2026 15:38:59 +0200 Subject: [PATCH] Fix sensor checks not working for STE2 --- README.md | 7 +++++++ internal/hwgroup/hwgroup.go | 6 ------ 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/README.md b/README.md index 7491540..4fd55bf 100644 --- a/README.md +++ b/README.md @@ -42,6 +42,13 @@ The warning and critical flags support thresholds in the common Nagios format (e check_hwgroup --community public --snmp-version 2c --port 1161 --host poseidon2-3266.internal --warning 10 --critical 20 --sensor 29448 [CRITICAL] - Poseidon2 3266 SNMP Supervisor v3.8.4 - Sensor value: 25.3|'HTemp Rack 19'=25.3;10;20 + +``` + +```bash +check_hwgroup --community public --snmp-version 1 --port 161 --host ste2.internal --warning 10 --critical 20 --sensor 52290 + +[WARNING] - STE2 r2, fw:1.5.9_2478 - Sensor value: 19.3|'Temp Rack'=19.3;10;20 ``` Check for a negative value: diff --git a/internal/hwgroup/hwgroup.go b/internal/hwgroup/hwgroup.go index 629949a..7bd647b 100644 --- a/internal/hwgroup/hwgroup.go +++ b/internal/hwgroup/hwgroup.go @@ -284,12 +284,6 @@ func (c *Client) QueryDeviceName() (string, error) { func (c *Client) QuerySensor(deviceType string, sensorID uint) (SensorResult, error) { var result SensorResult - _, ok := deviceTypeNums[deviceType] - - if !ok { - return result, fmt.Errorf("sensor checks are not supported for %s", deviceType) - } - errConnect := c.SNMPClient.Connect() if errConnect != nil { return result, fmt.Errorf("could not connect to device: %w", errConnect)