Skip to content

Commit 18d9d8b

Browse files
Warn explicitly on cyclical class dependencies
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
1 parent 617de74 commit 18d9d8b

5 files changed

Lines changed: 38 additions & 1 deletion

File tree

.github/actions/Build-PSModule/src/helpers/Build/Get-DependencyOrderedScriptFiles.ps1

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,8 @@ function Get-DependencyOrderedScriptFiles {
8888
}
8989

9090
if ($orderedPaths.Count -lt $sortedFiles.Count) {
91-
Write-Warning "Detected cyclical or unresolved class/enum dependencies. Falling back to lexical order for remaining files in [$($sortedFiles[0].DirectoryName)]."
91+
$remainingNames = ($remainingPaths | ForEach-Object { [System.IO.Path]::GetFileName($_) }) -join ', '
92+
Write-Warning "Cyclical class/enum dependencies detected in [$($sortedFiles[0].DirectoryName)]. Falling back to lexical order for unresolved files: $remainingNames"
9293
$remainingPaths | Sort-Object | ForEach-Object {
9394
$orderedPaths.Add($_)
9495
}
Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
class AlphaCirculationNode {
2+
[string] $Id
3+
[ZetaCirculationNode] $Next
4+
5+
AlphaCirculationNode([string]$Id, [ZetaCirculationNode]$Next) {
6+
$this.Id = $Id
7+
$this.Next = $Next
8+
}
9+
}
Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
class ZetaCirculationNode {
2+
[string] $Id
3+
[AlphaCirculationNode] $Previous
4+
5+
ZetaCirculationNode([string]$Id, [AlphaCirculationNode]$Previous) {
6+
$this.Id = $Id
7+
$this.Previous = $Previous
8+
}
9+
}
Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
class AlphaCirculationNode {
2+
[string] $Id
3+
[ZetaCirculationNode] $Next
4+
5+
AlphaCirculationNode([string]$Id, [ZetaCirculationNode]$Next) {
6+
$this.Id = $Id
7+
$this.Next = $Next
8+
}
9+
}
Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
class ZetaCirculationNode {
2+
[string] $Id
3+
[AlphaCirculationNode] $Previous
4+
5+
ZetaCirculationNode([string]$Id, [AlphaCirculationNode]$Previous) {
6+
$this.Id = $Id
7+
$this.Previous = $Previous
8+
}
9+
}

0 commit comments

Comments
 (0)