From 9c97fa48cd427188fea903bbe98e0e76cb74aa0c Mon Sep 17 00:00:00 2001 From: Tahmid Ahmed Date: Tue, 28 Jul 2026 22:28:04 -0400 Subject: [PATCH] Remove actuator basic auth (will be replaced by cluster) --- .../security/SecurityActuatorProperties.java | 6 ---- .../api/auth/security/SecurityConfig.java | 28 ------------------- src/main/resources/application.yml | 5 ---- 3 files changed, 39 deletions(-) delete mode 100644 src/main/java/org/patinanetwork/codebloom/api/auth/security/SecurityActuatorProperties.java diff --git a/src/main/java/org/patinanetwork/codebloom/api/auth/security/SecurityActuatorProperties.java b/src/main/java/org/patinanetwork/codebloom/api/auth/security/SecurityActuatorProperties.java deleted file mode 100644 index 96397e9c4..000000000 --- a/src/main/java/org/patinanetwork/codebloom/api/auth/security/SecurityActuatorProperties.java +++ /dev/null @@ -1,6 +0,0 @@ -package org.patinanetwork.codebloom.api.auth.security; - -import org.springframework.boot.context.properties.ConfigurationProperties; - -@ConfigurationProperties(prefix = "security.actuator") -public record SecurityActuatorProperties(String username, String password) {} diff --git a/src/main/java/org/patinanetwork/codebloom/api/auth/security/SecurityConfig.java b/src/main/java/org/patinanetwork/codebloom/api/auth/security/SecurityConfig.java index 8a4df10cf..3f9fe942f 100644 --- a/src/main/java/org/patinanetwork/codebloom/api/auth/security/SecurityConfig.java +++ b/src/main/java/org/patinanetwork/codebloom/api/auth/security/SecurityConfig.java @@ -1,6 +1,5 @@ package org.patinanetwork.codebloom.api.auth.security; -import org.springframework.boot.context.properties.EnableConfigurationProperties; import org.springframework.context.annotation.Bean; import org.springframework.context.annotation.Configuration; import org.springframework.core.annotation.Order; @@ -8,9 +7,6 @@ import org.springframework.security.config.annotation.web.configuration.EnableWebSecurity; import org.springframework.security.config.annotation.web.configuration.WebSecurityCustomizer; import org.springframework.security.config.annotation.web.configurers.AbstractHttpConfigurer; -import org.springframework.security.core.userdetails.User; -import org.springframework.security.core.userdetails.UserDetailsService; -import org.springframework.security.provisioning.InMemoryUserDetailsManager; import org.springframework.security.web.SecurityFilterChain; import org.springframework.security.web.authentication.AuthenticationSuccessHandler; @@ -20,7 +16,6 @@ * @see Authentication Documentation */ @Configuration -@EnableConfigurationProperties(SecurityActuatorProperties.class) @EnableWebSecurity public class SecurityConfig { @@ -30,29 +25,6 @@ public SecurityConfig(final AuthenticationSuccessHandler customAuthenticationSuc this.customAuthenticationSuccessHandler = customAuthenticationSuccessHandler; } - @Bean - UserDetailsService userDetailsService(SecurityActuatorProperties props) { - return new InMemoryUserDetailsManager(User.withUsername(props.username()) - .password("{noop}" + props.password()) - .roles("ACTUATOR") - .build()); - } - - /** - * Security filter chain for actuator endpoints with HTTP Basic authentication. This needs to be processed first - * (Order 1) to prevent OAuth from being applied. - */ - @Bean - @Order(1) - public SecurityFilterChain actuatorSecurityFilterChain(final HttpSecurity http) throws Exception { - http.securityMatcher("/actuator/**") - .csrf(AbstractHttpConfigurer::disable) - .authorizeHttpRequests(auth -> auth.anyRequest().hasRole("ACTUATOR")) - .httpBasic(basic -> {}); - - return http.build(); - } - @Bean @Order(2) SecurityFilterChain embedSecurity(HttpSecurity http) throws Exception { diff --git a/src/main/resources/application.yml b/src/main/resources/application.yml index 938f068ed..f88f634a1 100644 --- a/src/main/resources/application.yml +++ b/src/main/resources/application.yml @@ -106,11 +106,6 @@ management: prometheus: enabled: true -security: - actuator: - username: ${ACTUATOR_USERNAME} - password: ${ACTUATOR_PASSWORD} - secret: key: ${SECRET_KEY}