fix: revert subscribe to AsyncMock for backward compatibility

Author: allenporter

roborock/testing/channel.py

@@ -56,6 +56,11 @@ def __init__(self, is_local: bool = False):
         #   channel.publish.side_effect = RoborockException("timeout")
         self.publish = AsyncMock(side_effect=self._publish)
 
+        # AsyncMock wrapping _subscribe. Callers can replace side_effect to
+        # simulate subscription failures, e.g.:
+        #   channel.subscribe.side_effect = RoborockException("sub failed")
+        self.subscribe = AsyncMock(side_effect=self._subscribe)  # type: ignore[assignment]
+
         # AsyncMock wrapping _connect. Callers can replace side_effect to
         # simulate connection failures, e.g.:
         #   channel.connect.side_effect = RoborockException("refused")
@@ -100,10 +105,10 @@ async def _publish(self, message: RoborockMessage) -> None:
             response = self.response_queue.pop(0)
             self.notify_subscribers(response)
 
-    async def subscribe(self, callback: Callable[[RoborockMessage], None]) -> Callable[[], None]:
-        """Register a callback and return an unsubscribe function.
+    async def _subscribe(self, callback: Callable[[RoborockMessage], None]) -> Callable[[], None]:
+        """Default subscribe implementation.
 
-        This is a real method implementing the Channel protocol, not a mock.
+        Registers the callback and returns an unsubscribe function.
         """
         self.subscribers.append(callback)
         return lambda: self.subscribers.remove(callback)

roborock/testing/simulator.py

@@ -71,14 +71,14 @@ def __init__(
         )
 
         # MQTT channel is always present — all protocols use it.
-        self.mqtt_channel = FakeChannel(is_local=False)
+        self.mqtt_channel = FakeChannel(is_local=False)  # type: ignore[abstract]
         self.mqtt_channel.publish.side_effect = self._handle_mqtt_publish
 
         # Local channel is only used by V1 devices. A01/B01 (MQTT-only)
         # simulators should pass has_local_channel=False.
         self.local_channel: FakeChannel | None = None
         if has_local_channel:
-            self.local_channel = FakeChannel(is_local=True)
+            self.local_channel = FakeChannel(is_local=True)  # type: ignore[abstract]
             self.local_channel.publish.side_effect = self._handle_local_publish
 
     async def _handle_local_publish(self, message: RoborockMessage) -> None: