Skip to content

MSG_META_VIEW_TEAM logic in SelectionTranslator::translateGameMessage is bugged #2842

Description

@Caball009

SelectionTranslator::onMetaViewTeam

case GameMessage::MSG_META_VIEW_TEAM0:
case GameMessage::MSG_META_VIEW_TEAM1:
case GameMessage::MSG_META_VIEW_TEAM2:
case GameMessage::MSG_META_VIEW_TEAM3:
case GameMessage::MSG_META_VIEW_TEAM4:
case GameMessage::MSG_META_VIEW_TEAM5:
case GameMessage::MSG_META_VIEW_TEAM6:
case GameMessage::MSG_META_VIEW_TEAM7:
case GameMessage::MSG_META_VIEW_TEAM8:
case GameMessage::MSG_META_VIEW_TEAM9:
{
Int group = t - GameMessage::MSG_META_VIEW_TEAM0;
if ( group >= 1 && group <= 10 )

The above code appears to be a bug and should be instead:

Int group = t - GameMessage::MSG_META_ADD_TEAM0;
if ( group >= 0 && group < 10 )

Metadata

Metadata

Assignees

No one assigned

    Labels

    BugSomething is not working right, typically is user facingMinorSeverity: Minor < Major < Critical < Blocker

    Type

    No fields configured for Bug.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions