Skip to content

feat(ng-dev/release): implement --stage-only and build cleanup#3767

Merged
josephperrott merged 2 commits into
angular:mainfrom
josephperrott:task-2.1-stage-only
Jun 9, 2026
Merged

feat(ng-dev/release): implement --stage-only and build cleanup#3767
josephperrott merged 2 commits into
angular:mainfrom
josephperrott:task-2.1-stage-only

Conversation

@josephperrott

Copy link
Copy Markdown
Member

This PR implements the --stage-only flag for local release staging and automatic build directory cleanup, allowing early exit before publishing.

@angular-robot angular-robot Bot added the detected: feature PR contains a feature commit label Jun 8, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a "stage-only" mode to the release publishing tool, allowing users to run staging steps (bumping versions, generating changelogs, building, and creating a PR) and exit before publishing. This is achieved by adding a --stage-only CLI flag, a new StageOnlySuccessError to signal successful staging, and logic to clean up built package directories. The review feedback suggests optimizing the cleanup process by parallelizing directory deletion with Promise.all and removing a redundant stageOnly property declaration in ReleasePublishOptions since it is already inherited from ReleaseToolFlags.

Comment thread ng-dev/release/publish/actions.ts Outdated
Comment thread ng-dev/release/publish/cli.ts Outdated
@josephperrott josephperrott requested a review from alan-agius4 June 8, 2026 18:40
@josephperrott josephperrott added the action: merge The PR is ready for merge by the caretaker label Jun 8, 2026

@alan-agius4 alan-agius4 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott merged commit cef5e36 into angular:main Jun 9, 2026
16 checks passed
@josephperrott

Copy link
Copy Markdown
Member Author

This PR was merged into the repository. The changes were merged into the following branches:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker detected: feature PR contains a feature commit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants