From d424e8a9c1468e13ffee3ee4a934bc29201237d7 Mon Sep 17 00:00:00 2001 From: John Viegas Date: Thu, 2 Jul 2026 13:41:57 -0700 Subject: [PATCH] use class-based temporaryBucketName for s3 stability test buckets --- .../tests/s3/S3AsyncWithCrtAsyncHttpClientStabilityTest.java | 4 +++- .../stability/tests/s3/S3CrtAsyncClientStabilityTest.java | 4 +++- .../awssdk/stability/tests/s3/S3CrtClientStabilityTest.java | 4 +++- .../stability/tests/s3/S3MultipartJavaBasedStabilityTest.java | 4 +++- .../awssdk/stability/tests/s3/S3NettyAsyncStabilityTest.java | 4 +++- 5 files changed, 15 insertions(+), 5 deletions(-) diff --git a/test/stability-tests/src/it/java/software/amazon/awssdk/stability/tests/s3/S3AsyncWithCrtAsyncHttpClientStabilityTest.java b/test/stability-tests/src/it/java/software/amazon/awssdk/stability/tests/s3/S3AsyncWithCrtAsyncHttpClientStabilityTest.java index b675f82a6407..d7427f03b679 100644 --- a/test/stability-tests/src/it/java/software/amazon/awssdk/stability/tests/s3/S3AsyncWithCrtAsyncHttpClientStabilityTest.java +++ b/test/stability-tests/src/it/java/software/amazon/awssdk/stability/tests/s3/S3AsyncWithCrtAsyncHttpClientStabilityTest.java @@ -1,5 +1,7 @@ package software.amazon.awssdk.stability.tests.s3; +import static software.amazon.awssdk.testutils.service.S3BucketUtils.temporaryBucketName; + import java.time.Duration; import org.junit.jupiter.api.AfterAll; import org.junit.jupiter.api.BeforeAll; @@ -15,7 +17,7 @@ */ public class S3AsyncWithCrtAsyncHttpClientStabilityTest extends S3AsyncBaseStabilityTest { - private static String bucketName = "s3withcrtasyncclientstabilitytests" + System.currentTimeMillis(); + private static String bucketName = temporaryBucketName(S3AsyncWithCrtAsyncHttpClientStabilityTest.class); private static S3AsyncClient s3CrtClient; diff --git a/test/stability-tests/src/it/java/software/amazon/awssdk/stability/tests/s3/S3CrtAsyncClientStabilityTest.java b/test/stability-tests/src/it/java/software/amazon/awssdk/stability/tests/s3/S3CrtAsyncClientStabilityTest.java index 10c803700cb5..b2cd33cf0bc3 100644 --- a/test/stability-tests/src/it/java/software/amazon/awssdk/stability/tests/s3/S3CrtAsyncClientStabilityTest.java +++ b/test/stability-tests/src/it/java/software/amazon/awssdk/stability/tests/s3/S3CrtAsyncClientStabilityTest.java @@ -15,6 +15,8 @@ package software.amazon.awssdk.stability.tests.s3; +import static software.amazon.awssdk.testutils.service.S3BucketUtils.temporaryBucketName; + import org.junit.jupiter.api.AfterAll; import org.junit.jupiter.api.BeforeAll; import software.amazon.awssdk.crt.CrtResource; @@ -26,7 +28,7 @@ * Stability tests for {@link S3CrtAsyncClient} */ public class S3CrtAsyncClientStabilityTest extends S3AsyncBaseStabilityTest { - private static final String BUCKET_NAME = String.format("s3crtasyncclinetstabilitytests%d", System.currentTimeMillis()); + private static final String BUCKET_NAME = temporaryBucketName(S3CrtAsyncClientStabilityTest.class); private static final S3AsyncClient s3CrtAsyncClient; static { diff --git a/test/stability-tests/src/it/java/software/amazon/awssdk/stability/tests/s3/S3CrtClientStabilityTest.java b/test/stability-tests/src/it/java/software/amazon/awssdk/stability/tests/s3/S3CrtClientStabilityTest.java index dfbcbf26e6b3..713b1a4b9fd0 100644 --- a/test/stability-tests/src/it/java/software/amazon/awssdk/stability/tests/s3/S3CrtClientStabilityTest.java +++ b/test/stability-tests/src/it/java/software/amazon/awssdk/stability/tests/s3/S3CrtClientStabilityTest.java @@ -15,6 +15,8 @@ package software.amazon.awssdk.stability.tests.s3; +import static software.amazon.awssdk.testutils.service.S3BucketUtils.temporaryBucketName; + import java.time.Duration; import java.util.concurrent.Executors; import java.util.concurrent.TimeUnit; @@ -32,7 +34,7 @@ * Stability tests for S3 sync client using {@link AwsCrtHttpClient}. */ public class S3CrtClientStabilityTest extends S3BaseStabilityTest { - private static final String BUCKET_NAME = String.format("s3crthttpclientstabilitytests%d", System.currentTimeMillis()); + private static final String BUCKET_NAME = temporaryBucketName(S3CrtClientStabilityTest.class); private static final int CRT_CLIENT_THREAD_COUNT; diff --git a/test/stability-tests/src/it/java/software/amazon/awssdk/stability/tests/s3/S3MultipartJavaBasedStabilityTest.java b/test/stability-tests/src/it/java/software/amazon/awssdk/stability/tests/s3/S3MultipartJavaBasedStabilityTest.java index 6bda03809700..07ddfbfd9042 100644 --- a/test/stability-tests/src/it/java/software/amazon/awssdk/stability/tests/s3/S3MultipartJavaBasedStabilityTest.java +++ b/test/stability-tests/src/it/java/software/amazon/awssdk/stability/tests/s3/S3MultipartJavaBasedStabilityTest.java @@ -15,6 +15,8 @@ package software.amazon.awssdk.stability.tests.s3; +import static software.amazon.awssdk.testutils.service.S3BucketUtils.temporaryBucketName; + import java.time.Duration; import org.junit.jupiter.api.AfterAll; import org.junit.jupiter.api.BeforeAll; @@ -23,7 +25,7 @@ import software.amazon.awssdk.services.s3.S3AsyncClient; public class S3MultipartJavaBasedStabilityTest extends S3AsyncBaseStabilityTest { - private static final String BUCKET_NAME = String.format("s3multipartjavabasedstabilitytest%d", System.currentTimeMillis()); + private static final String BUCKET_NAME = temporaryBucketName(S3MultipartJavaBasedStabilityTest.class); private static final S3AsyncClient multipartJavaBasedClient; static { diff --git a/test/stability-tests/src/it/java/software/amazon/awssdk/stability/tests/s3/S3NettyAsyncStabilityTest.java b/test/stability-tests/src/it/java/software/amazon/awssdk/stability/tests/s3/S3NettyAsyncStabilityTest.java index e2bf02a42234..1f1e93bac828 100644 --- a/test/stability-tests/src/it/java/software/amazon/awssdk/stability/tests/s3/S3NettyAsyncStabilityTest.java +++ b/test/stability-tests/src/it/java/software/amazon/awssdk/stability/tests/s3/S3NettyAsyncStabilityTest.java @@ -1,5 +1,7 @@ package software.amazon.awssdk.stability.tests.s3; +import static software.amazon.awssdk.testutils.service.S3BucketUtils.temporaryBucketName; + import org.junit.jupiter.api.AfterAll; import org.junit.jupiter.api.BeforeAll; import software.amazon.awssdk.http.nio.netty.NettyNioAsyncHttpClient; @@ -12,7 +14,7 @@ public class S3NettyAsyncStabilityTest extends S3AsyncBaseStabilityTest { - private static String bucketName = "s3nettyasyncstabilitytests" + System.currentTimeMillis(); + private static String bucketName = temporaryBucketName(S3NettyAsyncStabilityTest.class); private static S3AsyncClient s3NettyClient;