Skip to content

Remove Renovate annotations from .tekton files already managed by MintMaker to prevent duplicate PRs #3422

Description

@fullsend-ai-retro

What happened

PR #3408 (by red-hat-konflux[bot]/MintMaker) and PR #3409 (by renovate[bot]) were opened within 2 minutes of each other on Jul 14, both updating the same e2e-tests digest in .tekton/cli-e2e-pull-request.yaml. Both received full review agent analysis and approval. Both were labeled ready-for-merge. PR #3408 was merged on Jul 16; PR #3409 was autoclosed by Renovate on Jul 17. Each duplicate PR consumed a review agent run and a retro agent run. Examining recent PR history shows this is not an isolated case — both bots also create overlapping PRs for golang version updates, Docker image tags, and Tekton pipeline versions.

What could go better

The .tekton/cli-e2e-pull-request.yaml file contains explicit Renovate annotations (# renovate: datasource=git-refs depName=...) that instruct Renovate to manage the e2e-tests digest. Meanwhile, MintMaker (Konflux's native dependency manager) independently detects and manages the same dependency. This overlap means every e2e-tests digest bump produces two PRs, two CI runs, two review agent runs, and two retro runs — doubling resource usage for zero incremental value. The duplicate PR also confuses the merge workflow: both get ready-for-merge labels, but only one can be merged.

Proposed change

Remove the '# renovate: datasource=git-refs depName=...' annotations from .tekton/cli-e2e-pull-request.yaml (and any other .tekton files with similar annotations), letting MintMaker handle these dependencies exclusively. Alternatively, add '.tekton/' to Renovate's ignorePaths in renovate.json so Renovate skips files that MintMaker manages. The Renovate customManagers section in renovate.json has a fileMatch for '.tekton/.*.yaml$' — removing this customManager entry would also resolve the overlap. Choose whichever approach aligns with the team's preferred dependency management strategy for Tekton pipeline configs.

Validation criteria

  1. After the change, a new e2e-tests commit should produce exactly one dependency update PR (from MintMaker), not two. 2. MintMaker continues to detect and update the digest in .tekton files as before. 3. Renovate continues to manage non-Tekton dependencies (Go modules, Docker images in Dockerfile, etc.) normally. 4. No 'autoclosed' duplicate PRs appear for .tekton dependency updates in the 2 weeks following the change.

Generated by retro agent from #3409

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions