Tinywasm fails to instantiate WASI modules with stubs

[Robbepop]

In the wasmi-benchmarks repo I tried to setup the startup benchmarks for the tinywasm interpreter.

However, from all the supported Wasm runtimes, it was the only one that failed to actually instantiate any of the WASI modules.
Note that I provided empty stubs for all of the imports and from what I can tell those imports should not be called anywhere during the Wasm module instantiation procedure.

With this setup even Wasm runtimes does explicitly do not support WASI should at least be able to instantiate those WASI modules - without executing them obviously.

Another observation: Wasm modules without a table/element segment (erc20, coremark-minimal, argon2) instantiate fine.

Repro:

1. Clone wasmi-benchmarks.
2. Checkout 5973722b68ac3a35268ac252ce8d5594586654a8.
3. Make can_run return just true to avoid the filters.
4. Run cargo bench --profile release startup --no-default-features -F tinywasm
5. See that the above command does not behave properly (does not halt).

Compared to other engines, e.g. cargo bench --profile release startup --no-default-features -F wasmi-v2 where the same startup benchmark works.

[explodingcamera]

Thanks for reporting this! I think I've found the issue: when a module has no start section, TinyWasm currently falls back to invoking an exported _start function which executes the entire wasi module on instantiation. I'm probably going to remove this fallback in the next release.

I think erc20, coremark-minimal and argon2 working correctly is due to all of them not exporting a _start function.

[explodingcamera]

I've pushed the changes to main now, and the startup benches now execute correctly on my machine.

[Robbepop]

Great. Thank you!
I will update the benchmarks once you published the fix to crates.io.

[Robbepop]

@explodingcamera
I have just checked out the new tinywasm v0.9.1 that seems to include the fix for this issue.
However, I can not confirm that this is fixed on wasmi-benchmarks when running any of the startup benchmarks, e.g.:

cargo bench --profile release --no-default-features -F tinywasm startup

Observation: TinyWasm hangs indefinitely.

Namely it hangs at this invocation:

let instance =
    tinywasm::ModuleInstance::instantiate(&mut store, &module, Some(imports)).unwrap();

Reproduce on this branch:
https://github.com/wasmi-labs/wasmi-benchmarks/tree/rf-tinywasm-hangs-repro

[explodingcamera]

@explodingcamera
I have just checked out the new tinywasm v0.9.1 that seems to include the fix for this issue.
However, I can not confirm that this is fixed on wasmi-benchmarks when running any of the startup benchmarks, e.g.:

cargo bench --profile release --no-default-features -F tinywasm startup

Observation: TinyWasm hangs indefinitely.

Namely it hangs at this invocation:

let instance =
    tinywasm::ModuleInstance::instantiate(&mut store, &module, Some(imports)).unwrap();

Reproduce on this branch:
https://github.com/wasmi-labs/wasmi-benchmarks/tree/rf-tinywasm-hangs-repro

Hi, 0.9.1 was released a few weeks ago and doesn't include the fix, I plan to release a 0.10 with the changes in a few days.