Compilation error on Clang 15.0.0

[wbernoudy]

I am getting this compilation error on Clang 15.0.0 (using Xcode 15.4.0 on MacOS):

../subprojects/reflect-cpp/src/rfl/env/Writer.cpp:139:39: error: reference to local binding 'key' declared in enclosing function 'rfl::env::Writer::end_object'
        portable_setenv((obj.prefix + key).c_str(), _v.value.c_str());

I suspect this is because of Clang 15's incomplete support for implicit capture of names (rather than variables, see this SO answer). After upgrading to Clang 17.0.0 (Xcode 16.4), I no longer see the error.

I'm only raising this as the README says that Clang 14+ is supported.

[liuzicheng1987]

This is weird, because we are explicitly testing this on Clang 15 in out Github Actions pipelines and we don't get the error.

However, the code line you are referring to is very new and was added to the main branch yesterday. So this is probably something we should take another look at. Thanks for reporting!

[liuzicheng1987]

@wbernoudy , here is a potential fix:

#705

Here is the branch:

https://github.com/getml/reflect-cpp/tree/f/env_clang_fix

Can you confirm it fixes the issue for you?