diff --git a/CHANGELOG.md b/CHANGELOG.md index 71c8d990122..5dbcde58f10 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -12,7 +12,7 @@ ### Improvements -- Reduce boxing to improve performance ([#5523](https://github.com/getsentry/sentry-java/pull/5523), [#5527](https://github.com/getsentry/sentry-java/pull/5527)) +- Reduce boxing to improve performance ([#5523](https://github.com/getsentry/sentry-java/pull/5523), [#5527](https://github.com/getsentry/sentry-java/pull/5527), [#5551](https://github.com/getsentry/sentry-java/pull/5551)) ### Dependencies diff --git a/sentry/api/sentry.api b/sentry/api/sentry.api index 4757be4894a..22f9366f738 100644 --- a/sentry/api/sentry.api +++ b/sentry/api/sentry.api @@ -384,7 +384,7 @@ public final class io/sentry/DataCategory : java/lang/Enum { public final class io/sentry/DateUtils { public static fun dateToNanos (Ljava/util/Date;)J public static fun dateToSeconds (Ljava/util/Date;)D - public static fun doubleToBigDecimal (Ljava/lang/Double;)Ljava/math/BigDecimal; + public static fun doubleToBigDecimal (D)Ljava/math/BigDecimal; public static fun getCurrentDateTime ()Ljava/util/Date; public static fun getDateTime (J)Ljava/util/Date; public static fun getDateTime (Ljava/lang/String;)Ljava/util/Date; diff --git a/sentry/src/main/java/io/sentry/DateUtils.java b/sentry/src/main/java/io/sentry/DateUtils.java index 5e55512ae70..b86bddeaad8 100644 --- a/sentry/src/main/java/io/sentry/DateUtils.java +++ b/sentry/src/main/java/io/sentry/DateUtils.java @@ -166,7 +166,7 @@ public static long secondsToNanos(final @NotNull long seconds) { return seconds * (1000L * 1000L * 1000L); } - public static @NotNull BigDecimal doubleToBigDecimal(final @NotNull Double value) { + public static @NotNull BigDecimal doubleToBigDecimal(final double value) { return BigDecimal.valueOf(value).setScale(6, RoundingMode.DOWN); } } diff --git a/sentry/src/main/java/io/sentry/ProfileChunk.java b/sentry/src/main/java/io/sentry/ProfileChunk.java index a6145ca8e9a..1d159030c1d 100644 --- a/sentry/src/main/java/io/sentry/ProfileChunk.java +++ b/sentry/src/main/java/io/sentry/ProfileChunk.java @@ -1,5 +1,7 @@ package io.sentry; +import static io.sentry.DateUtils.doubleToBigDecimal; + import io.sentry.profilemeasurements.ProfileMeasurement; import io.sentry.protocol.DebugMeta; import io.sentry.protocol.SdkVersion; @@ -8,8 +10,6 @@ import io.sentry.vendor.gson.stream.JsonToken; import java.io.File; import java.io.IOException; -import java.math.BigDecimal; -import java.math.RoundingMode; import java.util.HashMap; import java.util.Map; import java.util.Objects; @@ -264,10 +264,6 @@ public void serialize(final @NotNull ObjectWriter writer, final @NotNull ILogger writer.endObject(); } - private @NotNull BigDecimal doubleToBigDecimal(final @NotNull Double value) { - return BigDecimal.valueOf(value).setScale(6, RoundingMode.DOWN); - } - @Nullable @Override public Map getUnknown() { diff --git a/sentry/src/main/java/io/sentry/profilemeasurements/ProfileMeasurementValue.java b/sentry/src/main/java/io/sentry/profilemeasurements/ProfileMeasurementValue.java index 2f9ba5e1312..d27114c66ef 100644 --- a/sentry/src/main/java/io/sentry/profilemeasurements/ProfileMeasurementValue.java +++ b/sentry/src/main/java/io/sentry/profilemeasurements/ProfileMeasurementValue.java @@ -1,5 +1,7 @@ package io.sentry.profilemeasurements; +import static io.sentry.DateUtils.doubleToBigDecimal; + import io.sentry.DateUtils; import io.sentry.ILogger; import io.sentry.JsonDeserializer; @@ -10,8 +12,6 @@ import io.sentry.util.Objects; import io.sentry.vendor.gson.stream.JsonToken; import java.io.IOException; -import java.math.BigDecimal; -import java.math.RoundingMode; import java.util.Date; import java.util.Map; import java.util.concurrent.ConcurrentHashMap; @@ -92,10 +92,6 @@ public void serialize(final @NotNull ObjectWriter writer, final @NotNull ILogger writer.endObject(); } - private @NotNull BigDecimal doubleToBigDecimal(final @NotNull Double value) { - return BigDecimal.valueOf(value).setScale(6, RoundingMode.DOWN); - } - @Nullable @Override public Map getUnknown() { diff --git a/sentry/src/main/java/io/sentry/protocol/SentrySpan.java b/sentry/src/main/java/io/sentry/protocol/SentrySpan.java index 6274c8b00d7..58930ec1a87 100644 --- a/sentry/src/main/java/io/sentry/protocol/SentrySpan.java +++ b/sentry/src/main/java/io/sentry/protocol/SentrySpan.java @@ -1,5 +1,7 @@ package io.sentry.protocol; +import static io.sentry.DateUtils.doubleToBigDecimal; + import io.sentry.DateUtils; import io.sentry.ILogger; import io.sentry.JsonDeserializer; @@ -16,8 +18,6 @@ import io.sentry.util.Objects; import io.sentry.vendor.gson.stream.JsonToken; import java.io.IOException; -import java.math.BigDecimal; -import java.math.RoundingMode; import java.util.Date; import java.util.HashMap; import java.util.Map; @@ -230,10 +230,6 @@ public void serialize(final @NotNull ObjectWriter writer, final @NotNull ILogger writer.endObject(); } - private @NotNull BigDecimal doubleToBigDecimal(final @NotNull Double value) { - return BigDecimal.valueOf(value).setScale(6, RoundingMode.DOWN); - } - @Nullable @Override public Map getUnknown() { diff --git a/sentry/src/main/java/io/sentry/protocol/profiling/SentrySample.java b/sentry/src/main/java/io/sentry/protocol/profiling/SentrySample.java index 8f1c95641d5..af9053742d3 100644 --- a/sentry/src/main/java/io/sentry/protocol/profiling/SentrySample.java +++ b/sentry/src/main/java/io/sentry/protocol/profiling/SentrySample.java @@ -1,5 +1,7 @@ package io.sentry.protocol.profiling; +import static io.sentry.DateUtils.doubleToBigDecimal; + import io.sentry.ILogger; import io.sentry.JsonDeserializer; import io.sentry.JsonSerializable; @@ -8,8 +10,6 @@ import io.sentry.ObjectWriter; import io.sentry.vendor.gson.stream.JsonToken; import java.io.IOException; -import java.math.BigDecimal; -import java.math.RoundingMode; import java.util.HashMap; import java.util.Map; import org.jetbrains.annotations.ApiStatus; @@ -78,10 +78,6 @@ public void serialize(@NotNull ObjectWriter writer, @NotNull ILogger logger) thr writer.endObject(); } - private @NotNull BigDecimal doubleToBigDecimal(final @NotNull Double value) { - return BigDecimal.valueOf(value).setScale(6, RoundingMode.DOWN); - } - @Nullable @Override public Map getUnknown() {