From 50034792eed0c6a8bc3a2406660022f6788912d0 Mon Sep 17 00:00:00 2001 From: Chethan Thopaiah <41570277+ChethanT@users.noreply.github.com> Date: Thu, 2 Jul 2026 07:05:50 +0200 Subject: [PATCH 1/4] Remove references to obsoleted base 'Subcontractor - Dispatch List' action The base app action 'Subcontractor - Dispatch List' on the Work Center Card was obsoleted/removed. Remove the now-invalid modify() in the Subcontracting Work Center Card page extension and the two UI tests that referenced the action, which caused build error AL0271. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- .../SubcWorkCenterCard.PageExt.al | 4 -- .../SubcSubcontractingUITest.Codeunit.al | 44 ------------------- 2 files changed, 48 deletions(-) diff --git a/src/Apps/W1/Subcontracting/App/src/Manufacturing/SubcWorkCenterCard.PageExt.al b/src/Apps/W1/Subcontracting/App/src/Manufacturing/SubcWorkCenterCard.PageExt.al index cfcd353b6c..76190b858b 100644 --- a/src/Apps/W1/Subcontracting/App/src/Manufacturing/SubcWorkCenterCard.PageExt.al +++ b/src/Apps/W1/Subcontracting/App/src/Manufacturing/SubcWorkCenterCard.PageExt.al @@ -50,10 +50,6 @@ pageextension 99001506 "Subc. Work Center Card" extends "Work Center Card" } } } - modify("Subcontractor - Dispatch List") - { - Enabled = IsSubcontractingWorkCenter; - } } trigger OnOpenPage() diff --git a/src/Apps/W1/Subcontracting/Test/Tests/SubcSubcontractingUITest.Codeunit.al b/src/Apps/W1/Subcontracting/Test/Tests/SubcSubcontractingUITest.Codeunit.al index ae243b76e6..2a8411b1f5 100644 --- a/src/Apps/W1/Subcontracting/Test/Tests/SubcSubcontractingUITest.Codeunit.al +++ b/src/Apps/W1/Subcontracting/Test/Tests/SubcSubcontractingUITest.Codeunit.al @@ -277,50 +277,6 @@ codeunit 139990 "Subc. Subcontracting UI Test" WorkCenterCard.Close(); end; - [Test] - procedure WorkCenterCardDispatchListDisabledWhenNotSubcontracting() - var - WorkCenter: Record "Work Center"; - WorkCenterCard: TestPage "Work Center Card"; - begin - // [SCENARIO 633206] Subcontractor - Dispatch List action is disabled on Work Center Card when Work Center has no Subcontractor No. - Initialize(); - - // [GIVEN] A Work Center without a Subcontractor No. - LibraryMfgManagement.CreateWorkCenterWithCalendar(WorkCenter, 0); - - // [WHEN] The Work Center Card page is opened for the Work Center - WorkCenterCard.OpenEdit(); - WorkCenterCard.GotoRecord(WorkCenter); - - // [THEN] Subcontractor - Dispatch List action is not enabled - Assert.IsFalse(WorkCenterCard."Subcontractor - Dispatch List".Enabled(), SubcontractingActionsEnabledErr); - WorkCenterCard.Close(); - end; - - [Test] - procedure WorkCenterCardDispatchListEnabledWhenSubcontracting() - var - WorkCenter: Record "Work Center"; - WorkCenterCard: TestPage "Work Center Card"; - begin - // [SCENARIO 633206] Subcontractor - Dispatch List action is enabled on Work Center Card when Work Center has a Subcontractor No. - Initialize(); - - // [GIVEN] A Work Center with a Subcontractor No. - LibraryMfgManagement.CreateWorkCenterWithCalendar(WorkCenter, 0); - WorkCenter.Validate("Subcontractor No.", LibraryMfgManagement.CreateSubcontractorWithCurrency('')); - WorkCenter.Modify(true); - - // [WHEN] The Work Center Card page is opened for the Work Center - WorkCenterCard.OpenEdit(); - WorkCenterCard.GotoRecord(WorkCenter); - - // [THEN] Subcontractor - Dispatch List action is enabled - Assert.IsTrue(WorkCenterCard."Subcontractor - Dispatch List".Enabled(), SubcontractingActionsNotEnabledErr); - WorkCenterCard.Close(); - end; - [Test] procedure WorkCenterListSubcontractingActionsDisabledWhenNotSubcontracting() var From be128431bd14593e2dba489774f5bdd048efc2b9 Mon Sep 17 00:00:00 2001 From: Chethan Thopaiah <41570277+ChethanT@users.noreply.github.com> Date: Thu, 2 Jul 2026 07:13:45 +0200 Subject: [PATCH 2/4] Add Subcontractor - Dispatch List action to Subcontracting Work Center Card The base app action was removed, leaving the local report 99001504 'Subc. Dispatching List' unreachable from the Work Center Card. Add a replacement action in the Subcontracting action group that runs the report filtered to the work center's subcontractor, enabled only for subcontracting work centers. Restore the two UI tests covering the action's enabled state. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- .../SubcWorkCenterCard.PageExt.al | 17 +++++++ .../SubcSubcontractingUITest.Codeunit.al | 44 +++++++++++++++++++ 2 files changed, 61 insertions(+) diff --git a/src/Apps/W1/Subcontracting/App/src/Manufacturing/SubcWorkCenterCard.PageExt.al b/src/Apps/W1/Subcontracting/App/src/Manufacturing/SubcWorkCenterCard.PageExt.al index 76190b858b..68666033bb 100644 --- a/src/Apps/W1/Subcontracting/App/src/Manufacturing/SubcWorkCenterCard.PageExt.al +++ b/src/Apps/W1/Subcontracting/App/src/Manufacturing/SubcWorkCenterCard.PageExt.al @@ -5,6 +5,7 @@ namespace Microsoft.Manufacturing.Subcontracting; using Microsoft.Manufacturing.WorkCenter; +using Microsoft.Purchases.Document; pageextension 99001506 "Subc. Work Center Card" extends "Work Center Card" { @@ -48,6 +49,22 @@ pageextension 99001506 "Subc. Work Center Card" extends "Work Center Card" RunPageLink = "Work Center No." = field("No."); ToolTip = 'View the Subcontracting WIP Entries that track work-in-progress quantities at this work center''s subcontracting location.'; } + action("Subcontractor - Dispatch List") + { + ApplicationArea = Subcontracting; + Caption = 'Subcontractor - Dispatch List'; + Enabled = IsSubcontractingWorkCenter; + Image = Print; + ToolTip = 'Print the dispatching list for the subcontractor assigned to this work center.'; + + trigger OnAction() + var + PurchaseHeader: Record "Purchase Header"; + begin + PurchaseHeader.SetRange("Buy-from Vendor No.", Rec."Subcontractor No."); + Report.Run(Report::"Subc. Dispatching List", true, false, PurchaseHeader); + end; + } } } } diff --git a/src/Apps/W1/Subcontracting/Test/Tests/SubcSubcontractingUITest.Codeunit.al b/src/Apps/W1/Subcontracting/Test/Tests/SubcSubcontractingUITest.Codeunit.al index 2a8411b1f5..ae243b76e6 100644 --- a/src/Apps/W1/Subcontracting/Test/Tests/SubcSubcontractingUITest.Codeunit.al +++ b/src/Apps/W1/Subcontracting/Test/Tests/SubcSubcontractingUITest.Codeunit.al @@ -277,6 +277,50 @@ codeunit 139990 "Subc. Subcontracting UI Test" WorkCenterCard.Close(); end; + [Test] + procedure WorkCenterCardDispatchListDisabledWhenNotSubcontracting() + var + WorkCenter: Record "Work Center"; + WorkCenterCard: TestPage "Work Center Card"; + begin + // [SCENARIO 633206] Subcontractor - Dispatch List action is disabled on Work Center Card when Work Center has no Subcontractor No. + Initialize(); + + // [GIVEN] A Work Center without a Subcontractor No. + LibraryMfgManagement.CreateWorkCenterWithCalendar(WorkCenter, 0); + + // [WHEN] The Work Center Card page is opened for the Work Center + WorkCenterCard.OpenEdit(); + WorkCenterCard.GotoRecord(WorkCenter); + + // [THEN] Subcontractor - Dispatch List action is not enabled + Assert.IsFalse(WorkCenterCard."Subcontractor - Dispatch List".Enabled(), SubcontractingActionsEnabledErr); + WorkCenterCard.Close(); + end; + + [Test] + procedure WorkCenterCardDispatchListEnabledWhenSubcontracting() + var + WorkCenter: Record "Work Center"; + WorkCenterCard: TestPage "Work Center Card"; + begin + // [SCENARIO 633206] Subcontractor - Dispatch List action is enabled on Work Center Card when Work Center has a Subcontractor No. + Initialize(); + + // [GIVEN] A Work Center with a Subcontractor No. + LibraryMfgManagement.CreateWorkCenterWithCalendar(WorkCenter, 0); + WorkCenter.Validate("Subcontractor No.", LibraryMfgManagement.CreateSubcontractorWithCurrency('')); + WorkCenter.Modify(true); + + // [WHEN] The Work Center Card page is opened for the Work Center + WorkCenterCard.OpenEdit(); + WorkCenterCard.GotoRecord(WorkCenter); + + // [THEN] Subcontractor - Dispatch List action is enabled + Assert.IsTrue(WorkCenterCard."Subcontractor - Dispatch List".Enabled(), SubcontractingActionsNotEnabledErr); + WorkCenterCard.Close(); + end; + [Test] procedure WorkCenterListSubcontractingActionsDisabledWhenNotSubcontracting() var From 31f615a165d232b1da7d16976e8eaab1dcbd1914 Mon Sep 17 00:00:00 2001 From: Chethan Thopaiah <41570277+ChethanT@users.noreply.github.com> Date: Thu, 2 Jul 2026 08:06:58 +0200 Subject: [PATCH 3/4] added action --- .../App/src/Manufacturing/SubcWorkCenterCard.PageExt.al | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Apps/W1/Subcontracting/App/src/Manufacturing/SubcWorkCenterCard.PageExt.al b/src/Apps/W1/Subcontracting/App/src/Manufacturing/SubcWorkCenterCard.PageExt.al index 68666033bb..eb88582ca5 100644 --- a/src/Apps/W1/Subcontracting/App/src/Manufacturing/SubcWorkCenterCard.PageExt.al +++ b/src/Apps/W1/Subcontracting/App/src/Manufacturing/SubcWorkCenterCard.PageExt.al @@ -49,7 +49,7 @@ pageextension 99001506 "Subc. Work Center Card" extends "Work Center Card" RunPageLink = "Work Center No." = field("No."); ToolTip = 'View the Subcontracting WIP Entries that track work-in-progress quantities at this work center''s subcontracting location.'; } - action("Subcontractor - Dispatch List") + action("Subcontractor Dispatch List") { ApplicationArea = Subcontracting; Caption = 'Subcontractor - Dispatch List'; From 3f8b4db32c2a167a9747d9f640540db00964a254 Mon Sep 17 00:00:00 2001 From: Chethan Thopaiah <41570277+ChethanT@users.noreply.github.com> Date: Tue, 7 Jul 2026 16:08:54 +0200 Subject: [PATCH 4/4] Fix UI test references to renamed Subcontractor Dispatch List action --- .../Test/Tests/SubcSubcontractingUITest.Codeunit.al | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Apps/W1/Subcontracting/Test/Tests/SubcSubcontractingUITest.Codeunit.al b/src/Apps/W1/Subcontracting/Test/Tests/SubcSubcontractingUITest.Codeunit.al index ae243b76e6..8c796f77fe 100644 --- a/src/Apps/W1/Subcontracting/Test/Tests/SubcSubcontractingUITest.Codeunit.al +++ b/src/Apps/W1/Subcontracting/Test/Tests/SubcSubcontractingUITest.Codeunit.al @@ -294,7 +294,7 @@ codeunit 139990 "Subc. Subcontracting UI Test" WorkCenterCard.GotoRecord(WorkCenter); // [THEN] Subcontractor - Dispatch List action is not enabled - Assert.IsFalse(WorkCenterCard."Subcontractor - Dispatch List".Enabled(), SubcontractingActionsEnabledErr); + Assert.IsFalse(WorkCenterCard."Subcontractor Dispatch List".Enabled(), SubcontractingActionsEnabledErr); WorkCenterCard.Close(); end; @@ -317,7 +317,7 @@ codeunit 139990 "Subc. Subcontracting UI Test" WorkCenterCard.GotoRecord(WorkCenter); // [THEN] Subcontractor - Dispatch List action is enabled - Assert.IsTrue(WorkCenterCard."Subcontractor - Dispatch List".Enabled(), SubcontractingActionsNotEnabledErr); + Assert.IsTrue(WorkCenterCard."Subcontractor Dispatch List".Enabled(), SubcontractingActionsNotEnabledErr); WorkCenterCard.Close(); end;