Fixes for Copilot suggestions

Author: bobbrow

Extension/test/common/selectTests.ts

@@ -74,13 +74,17 @@ export async function getTestInfo(...scenarioOptions: (string | undefined)[]) {
 }
 
 /**
- * When running tests on GitHub, this function determines if the tests should be skipped based on
- * whether the binary version copied for tests is compatible with the minimum required version.
- * The minimum required binary version is defined in the `binaryCompat.json` file and changes when
- * there are breaking changes in the communication protocol or messages.
+ * When running tests after using `yarn install-and-copy-binaries-for-test`, this function determines
+ * if the tests should be skipped based on whether the binary version copied for tests is compatible
+ * with the minimum required version. The minimum required binary version is defined in the
+ * `minBinaryVersion.json` file and changes when there are breaking changes in the communication
+ * protocol or messages.
  *
- * When running locally, the function will always return false since you're expected to have the
- * correct binaries available.
+ * When running locally, the function is expected to always return false since you're more likely to
+ * have the correct binaries available. If you ever ran `yarn install-and-copy-binaries-for-test` locally
+ * and the binaries are too old, this function will return true and skip the tests. The remedy is to
+ * delete the `bin/binaryVersion.json` file and/or re-run `yarn install-and-copy-binaries-for-test` to
+ * get the latest binaries.
  * @returns A promise that resolves to a boolean indicating whether the tests should be skipped.
  */
 async function shouldSkipTests(): Promise<boolean> {
@@ -99,7 +103,7 @@ async function shouldSkipTests(): Promise<boolean> {
             }
             if (tooOld) {
                 console.warn(`\nBinary-dependent tests SKIPPED: installed binary version ${binaryVersion.version} is below the required minimum ${binaryCompat.minBinaryVersion}.`);
-                console.warn(`Tests will re-enable automatically once binaries >= ${binaryCompat.minBinaryVersion} are installed.\n`);
+                console.warn(`Tests will re-enable automatically once binaries >= ${binaryCompat.minBinaryVersion} are installed or 'bin/binaryVersion.json' is removed.\n`);
                 return true;
             }
         }
@@ -129,7 +133,7 @@ export function run(testsRoot: string, cb: (error: any, failures?: number) => vo
             return;
         }
 
-        const files = await glob(`${$root}/dist/test/scenarios/${name}/tests/**/**.test.js`);
+        const files = await glob(`${$root}/dist/test/scenarios/${name}/tests/**/**.test.js`).catch(returns.none);
         try {
             if (!files.length) {
                 throw new Error(`Unable to find unit tests for ${name} at '${$root}/dist/test/scenarios/${name}/tests/**/**.test.js'`);

Extension/test/scenarios/RunWithoutDebugging/tests/runWithoutDebugging.terminals.test.ts

@@ -108,7 +108,7 @@ suite('Run Without Debugging Terminal and Arguments Test', function (this: Mocha
         'two words',
         path.join(workspacePath, 'input folder', 'three words.txt')
     ];
-    const skipExternalConsole = process.env.SCENARIO_ARGS?.includes('skipExternalConsole');
+    const skipExternalConsole = process.env.SCENARIO_ARGS?.split(',').includes('skipExternalConsole');
 
     suiteSetup(async function (): Promise<void> {
         const extension: vscode.Extension<any> = vscode.extensions.getExtension('ms-vscode.cpptools') || assert.fail('Extension not found');