From 4758620688bc82fc9848c1ab2a96babc4b782cd0 Mon Sep 17 00:00:00 2001 From: Gina Peter Banyard Date: Thu, 23 Jul 2026 22:57:57 +0100 Subject: [PATCH] standard/filestats.c: use RETURN_BOOL() when possible --- ext/standard/filestat.c | 18 +++--------------- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/ext/standard/filestat.c b/ext/standard/filestat.c index f7bda3c66bab..7dcfecf1f872 100644 --- a/ext/standard/filestat.c +++ b/ext/standard/filestat.c @@ -339,11 +339,7 @@ static void php_do_chgrp(INTERNAL_FUNCTION_PARAMETERS, int do_lchgrp) /* {{{ */ value = &group_long; } - if(wrapper->wops->stream_metadata(wrapper, filename, option, value, NULL)) { - RETURN_TRUE; - } else { - RETURN_FALSE; - } + RETURN_BOOL(wrapper->wops->stream_metadata(wrapper, filename, option, value, NULL)); } else { #ifndef PHP_WIN32 /* On Windows, we expect regular chgrp to fail silently by default */ @@ -480,11 +476,7 @@ static void php_do_chown(INTERNAL_FUNCTION_PARAMETERS, int do_lchown) /* {{{ */ value = &user_long; } - if(wrapper->wops->stream_metadata(wrapper, filename, option, value, NULL)) { - RETURN_TRUE; - } else { - RETURN_FALSE; - } + RETURN_BOOL(wrapper->wops->stream_metadata(wrapper, filename, option, value, NULL)); } else { #ifndef PHP_WIN32 /* On Windows, we expect regular chown to fail silently by default */ @@ -638,11 +630,7 @@ PHP_FUNCTION(touch) wrapper = php_stream_locate_url_wrapper(filename, NULL, 0); if(wrapper != &php_plain_files_wrapper || strncasecmp("file://", filename, 7) == 0) { if(wrapper && wrapper->wops->stream_metadata) { - if(wrapper->wops->stream_metadata(wrapper, filename, PHP_STREAM_META_TOUCH, newtime, NULL)) { - RETURN_TRUE; - } else { - RETURN_FALSE; - } + RETURN_BOOL(wrapper->wops->stream_metadata(wrapper, filename, PHP_STREAM_META_TOUCH, newtime, NULL)); } else { php_stream *stream; if(!filetime_is_null || !fileatime_is_null) {