revert ranges::unique/remove_if to iterator form; drop cppcheck suppressions

Author: Cameron Custer

tests/.config/.cppcheck_suppression_list

@@ -60,10 +60,5 @@ unusedFunction:../kactl/content/data-structures/UnionFind.h:14
 unusedFunction:../kactl/content/number-theory/ModPow.h:13
 unusedFunction:../kactl/stress-tests/utilities/genTree.h:49
 containerOutOfBounds:../library/data_structures_[l,r)/uncommon/permutation_tree.hpp:85
-mismatchingContainerExpression:library_checker_aizu_tests/data_structures/bit_ordered_set.test.cpp:20
-mismatchingContainerExpression:library_checker_aizu_tests/data_structures/kth_smallest_pst.test.cpp:13
-mismatchingContainerExpression:library_checker_aizu_tests/data_structures/mode_query.test.cpp:13
-mismatchingContainerExpression:library_checker_aizu_tests/strings/sa_sort_pairs.test.cpp:13
-mismatchingContainerExpression:library_checker_aizu_tests/strings/single_matching_bs.test.cpp:73
 ctuOneDefinitionRuleViolation:../library/data_structures_[l,r)/bit.hpp:15
 ctuOneDefinitionRuleViolation:../library/data_structures_[l,r)/lazy_seg_tree.hpp:4

tests/library_checker_aizu_tests/data_structures/bit_ordered_set.test.cpp

@@ -17,8 +17,7 @@ int main() {
     compress.push_back(x);
   }
   ranges::sort(compress);
-  compress.erase(begin(ranges::unique(compress)),
-    end(compress));
+  compress.erase(unique(all(compress)), end(compress));
   BIT bit(sz(compress));
   auto get_compressed_idx = [&](int val) -> int {
     int l = 0, r = sz(compress);

tests/library_checker_aizu_tests/data_structures/kth_smallest_pst.test.cpp

@@ -10,7 +10,7 @@ int main() {
   rep(i, 0, n) cin >> arr[i];
   vi sorted(arr);
   ranges::sort(sorted);
-  sorted.erase(begin(ranges::unique(sorted)), end(sorted));
+  sorted.erase(unique(all(sorted)), end(sorted));
   for (int& val : arr) {
     int start = 0, end = sz(sorted);
     while (start + 1 < end) {

tests/library_checker_aizu_tests/data_structures/mode_query.test.cpp

@@ -10,7 +10,7 @@ int main() {
   rep(i, 0, n) cin >> a[i];
   vi comp(a);
   ranges::sort(comp);
-  comp.erase(begin(ranges::unique(comp)), end(comp));
+  comp.erase(unique(all(comp)), end(comp));
   for (int& val : a) {
     int start = 0, end = sz(comp);
     while (start + 1 < end) {

tests/library_checker_aizu_tests/handmade_tests/seg_tree_find.test.cpp

@@ -51,7 +51,7 @@ int main() {
       else assert(cur_le == prv_ri);
     }
     ranges::sort(rngs);
-    assert(empty(ranges::unique(rngs)));
+    assert(unique(all(rngs)) == end(rngs));
     reset();
     assert(
       pos == rv(rev.find_last(rv(r - 1), rv(l) + 1, f)));
@@ -67,7 +67,7 @@ int main() {
       else assert(prv_le == cur_ri);
     }
     ranges::sort(rngs);
-    assert(empty(ranges::unique(rngs)));
+    assert(unique(all(rngs)) == end(rngs));
   }
   cout << "Hello World\n";
   return 0;

tests/library_checker_aizu_tests/strings/sa_sort_pairs.test.cpp

@@ -10,8 +10,7 @@ int main() {
   for (int& x : arr) cin >> x;
   vi compress(arr);
   ranges::sort(compress);
-  compress.erase(begin(ranges::unique(compress)),
-    end(compress));
+  compress.erase(unique(all(compress)), end(compress));
   for (int& x : arr) {
     int l = -1, r = int(sz(compress));
     while (r - l > 1) {

tests/library_checker_aizu_tests/strings/single_matching_bs.test.cpp

@@ -70,8 +70,8 @@ int main() {
       vi matches_other(begin(lq_both.sa) + sa_le2,
         begin(lq_both.sa) + sa_ri2);
       matches_other.erase(
-        begin(ranges::remove_if(matches_other,
-          [&](int val) { return val >= sz(s) + 1; })),
+        remove_if(all(matches_other),
+          [&](int val) { return val >= sz(s) + 1; }),
         end(matches_other));
       ranges::sort(matches_other);
       assert(matches == matches_other);