standardize tests: template macros, c++20 ranges, naming conventions (#226)

* standardize tests: template macros, c++20 ranges, naming conventions

* keep iterator-form unique/remove_if in tests (ranges:: form is not a strict win)

* Revert "keep iterator-form unique/remove_if in tests (ranges:: form is not a strict win)"

This reverts commit 04f35f6.

* use <bit> instead of __lg in seg_tree_midpoint test

* use ranges::count in lcs_dp test

* brace rep-if-else bodies to fix -Wmisleading-indentation

* suppress cppcheck mismatchingContainerExpression false positives on ranges::unique/remove_if

* revert ranges::unique/remove_if to iterator form; drop cppcheck suppressions

---------

Co-authored-by: Cameron Custer <cam@augmentcode.com>

Author: cameroncuster

tests/library_checker_aizu_tests/cd_asserts.hpp

@@ -1,8 +1,8 @@
 #pragma once
 #include "../../library/trees/centroid_decomp.hpp"
-void cd_asserts(vector<vector<int>> adj) {
-  vector<int> decomp_size(sz(adj), -1);
-  vector<int> naive_par_decomp(sz(adj), -1);
+void cd_asserts(vector<vi> adj) {
+  vi decomp_size(sz(adj), -1);
+  vi naive_par_decomp(sz(adj), -1);
   vi par = cd(adj, [&](int cent) -> void {
     assert(decomp_size[cent] == -1);
     auto dfs = [&](auto&& self, int u, int p) -> int {

tests/library_checker_aizu_tests/compress_tree_asserts.hpp

@@ -5,23 +5,22 @@
 #undef RMQ
 #undef LCA
 #include "../../library/contest/random.hpp"
-void compress_tree_asserts(vector<vector<int>> adj,
-  LCA& lc_rm) {
+void compress_tree_asserts(vector<vi> adj, LCA& lc_rm) {
   int n = sz(adj);
-  vector<bool> used(n);
+  vector<bool> vis(n);
   KACTL_LCA kactl_lca(adj);
   {
     auto [parent, to_node] = lc_rm.compress_tree({});
     assert(empty(parent) && empty(to_node));
   }
-  for (int tests = 0; tests < 10; tests++) {
-    vector<int> subset;
+  rep(tests, 0, 10) {
+    vi subset;
     {
       int subset_size = rnd(1, min(n, 10));
       while (subset_size--) {
         int u = rnd(0, n - 1);
-        if (!used[u]) {
-          used[u] = 1;
+        if (!vis[u]) {
+          vis[u] = 1;
           subset.push_back(u);
         }
       }
@@ -30,13 +29,13 @@ void compress_tree_asserts(vector<vector<int>> adj,
     auto [lc_rm_parent, lc_rm_to_node] =
       lc_rm.compress_tree(subset);
     assert(sz(lc_rm_parent) == sz(kactl_res));
-    for (int i = 0; i < sz(lc_rm_parent); i++) {
+    rep(i, 0, sz(lc_rm_parent)) {
       assert(lc_rm_to_node[i] == kactl_res[i].second);
       assert(lc_rm_parent[i] < i);
       if (i > 0)
         assert(lc_rm_parent[i] == kactl_res[i].first);
       else assert(lc_rm_parent[i] == -1);
     }
-    for (int u : subset) used[u] = 0;
+    for (int u : subset) vis[u] = 0;
   }
 }

tests/library_checker_aizu_tests/convolution/gcd_convolution.test.cpp

@@ -2,15 +2,15 @@
   "https://judge.yosupo.jp/problem/gcd_convolution"
 #include "../template.hpp"
 #include "../../../library/convolution/gcd_convolution.hpp"
-istream& operator>>(istream& is, vector<int>& v) {
-  for (int i = 1; i < sz(v); i++) is >> v[i];
+istream& operator>>(istream& is, vi& v) {
+  rep(i, 1, sz(v)) is >> v[i];
   return is;
 }
 int main() {
   cin.tie(0)->sync_with_stdio(0);
   int n;
   cin >> n;
-  vector<int> a(n + 1), b(n + 1);
+  vi a(n + 1), b(n + 1);
   cin >> a >> b;
   auto c = gcd_convolution(a, b);
   for (int i = 1; i <= n; i++) cout << c[i] << ' ';

tests/library_checker_aizu_tests/convolution/lcm_convolution.test.cpp

@@ -2,15 +2,15 @@
   "https://judge.yosupo.jp/problem/lcm_convolution"
 #include "../template.hpp"
 #include "../../../library/convolution/lcm_convolution.hpp"
-istream& operator>>(istream& is, vector<int>& v) {
-  for (int i = 1; i < sz(v); i++) is >> v[i];
+istream& operator>>(istream& is, vi& v) {
+  rep(i, 1, sz(v)) is >> v[i];
   return is;
 }
 int main() {
   cin.tie(0)->sync_with_stdio(0);
   int n;
   cin >> n;
-  vector<int> a(n + 1), b(n + 1);
+  vi a(n + 1), b(n + 1);
   cin >> a >> b;
   auto c = lcm_convolution(a, b);
   for (int i = 1; i <= n; i++) cout << c[i] << ' ';

tests/library_checker_aizu_tests/convolution/min_plus_convolution.test.cpp

@@ -2,15 +2,15 @@
   "https://judge.yosupo.jp/problem/min_plus_convolution_convex_arbitrary"
 #include "../template.hpp"
 #include "../../../library/convolution/min_plus_convolution_convex_and_arbitrary.hpp"
-istream& operator>>(istream& is, vector<int>& v) {
+istream& operator>>(istream& is, vi& v) {
   for (int& e : v) is >> e;
   return is;
 }
 int main() {
   cin.tie(0)->sync_with_stdio(0);
   int n, m;
   cin >> n >> m;
-  vector<int> convex(n), arbitrary(m);
+  vi convex(n), arbitrary(m);
   cin >> convex >> arbitrary;
   auto res = min_plus(convex, arbitrary);
   for (int r : res) cout << r << ' ';

tests/library_checker_aizu_tests/convolution/xor_convolution.test.cpp

@@ -2,8 +2,8 @@
   "https://judge.yosupo.jp/problem/bitwise_xor_convolution"
 #include "../template.hpp"
 #include "../../../library/convolution/xor_convolution.hpp"
-istream& operator>>(istream& is, vector<int>& v) {
-  for (int i = 0; i < sz(v); i++) is >> v[i];
+istream& operator>>(istream& is, vi& v) {
+  rep(i, 0, sz(v)) is >> v[i];
   return is;
 }
 int main() {
@@ -13,7 +13,7 @@ int main() {
   vi a(1 << n), b(1 << n);
   cin >> a >> b;
   vi c = xor_conv(a, b);
-  for (int i = 0; i < (1 << n); i++) cout << c[i] << ' ';
+  rep(i, 0, (1 << n)) cout << c[i] << ' ';
   cout << '\n';
   return 0;
 }

tests/library_checker_aizu_tests/data_structures/binary_search_example.test.cpp

@@ -10,11 +10,10 @@ int main() {
   }
   int n, s;
   cin >> n >> s;
-  vector<int> a(n);
-  for (int i = 0; i < n; i++) cin >> a[i];
-  vector<int> pref_sum(a);
-  for (int i = 1; i < n; i++)
-    pref_sum[i] += pref_sum[i - 1];
+  vi a(n);
+  rep(i, 0, n) cin >> a[i];
+  vi pref_sum(a);
+  rep(i, 1, n) pref_sum[i] += pref_sum[i - 1];
   auto sum = [&](int l, int r) -> int { //[l,r]
     int res = pref_sum[r];
     if (l) res -= pref_sum[l - 1];
@@ -25,11 +24,11 @@ int main() {
     return 0;
   }
   int res = n;
-  for (int i = 0; i < n; i++) {
+  rep(i, 0, n) {
     if (sum(i, n - 1) < s) break;
-    int curr = *ranges::partition_point(views::iota(i, n),
+    int cur = *ranges::partition_point(views::iota(i, n),
       [&](int x) -> bool { return sum(i, x) < s; });
-    res = min(res, curr - i + 1);
+    res = min(res, cur - i + 1);
   }
   cout << res << '\n';
   return 0;

tests/library_checker_aizu_tests/data_structures/bit.test.cpp

@@ -10,8 +10,8 @@ int main() {
   int n, q;
   cin >> n >> q;
   vector<ll> arr(n);
-  vector<int> arr_int(n);
-  for (int i = 0; i < n; i++) {
+  vi arr_int(n);
+  rep(i, 0, n) {
     cin >> arr[i];
     arr_int[i] = int(arr[i]);
   }
@@ -21,7 +21,7 @@ int main() {
   vector<ll> suf_sum(n);
   partial_sum(rbegin(arr), rend(arr), rbegin(suf_sum));
   bit_rupq bit_i(suf_sum);
-  for (int i = 0; i < n; i++) {
+  rep(i, 0, n) {
     assert(arr[i] == bit.query(i, i + 1));
     assert(bit_i.get_index(i) == bit.query(i, n));
     assert(bit_i.get_index(i) == suf_sum[i]);

tests/library_checker_aizu_tests/data_structures/bit_inc.test.cpp

@@ -7,7 +7,7 @@ int main() {
   int n, q;
   cin >> n >> q;
   BIT bit(n);
-  for (int i = 0; i < n; i++) {
+  rep(i, 0, n) {
     int val;
     cin >> val;
     bit.update(i, val);

tests/library_checker_aizu_tests/data_structures/bit_inc_walk.test.cpp

@@ -8,7 +8,7 @@ int main() {
   string s;
   cin >> n >> q >> s;
   vector<ll> init(n);
-  for (int i = 0; i < n; i++) init[i] = s[i] - '0';
+  rep(i, 0, n) init[i] = s[i] - '0';
   BIT bit(init);
   while (q--) {
     int type, k;