Skip to content

added check prop 'visible' on undefined#111

Open
devdammit wants to merge 2 commits into
react-component:masterfrom
devdammit:master
Open

added check prop 'visible' on undefined#111
devdammit wants to merge 2 commits into
react-component:masterfrom
devdammit:master

Conversation

@devdammit

@devdammit devdammit commented Dec 25, 2017

Copy link
Copy Markdown

close #95

@yesmeck

yesmeck commented Dec 26, 2017

Copy link
Copy Markdown
Member

@devdammit Thanks, could you write a test?

@yesmeck yesmeck self-requested a review December 26, 2017 13:21
@devdammit

Copy link
Copy Markdown
Author

@yesmeck, sure. :)

@devdammit

Copy link
Copy Markdown
Author

@yesmeck, I close the PR or something needs to be done? :)

@evanhli

evanhli commented Oct 15, 2018

Copy link
Copy Markdown

Hey can this get merged in? Im building a feature that relies on visible to be undefined @yesmeck

@FlorisVeldhuizen

Copy link
Copy Markdown

Hi, can this be approved :)?

@yoyo837

yoyo837 commented Feb 3, 2023

Copy link
Copy Markdown
Member

Rebase please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Determining the availability of props.visible

5 participants