From d6f04e7e70e05f002bb53daf7e97be9041725d1c Mon Sep 17 00:00:00 2001 From: Hiroshi SHIBATA Date: Mon, 22 Jun 2026 13:26:27 +0900 Subject: [PATCH 1/2] Fix broken OpenSSL::SSL::SSLContext doc links The {label}[url] markup pointed at OpenSSL::SSL::SSL::Context#..., which RDoc emitted verbatim as a relative href and never resolved. Point them at the full SSLContext documentation URLs instead. https://github.com/ruby/net-http/issues/288 https://github.com/ruby/net-http/issues/289 https://github.com/ruby/net-http/issues/290 https://github.com/ruby/net-http/issues/291 https://github.com/ruby/net-http/issues/293 https://github.com/ruby/net-http/issues/294 Co-Authored-By: Claude Opus 4.8 --- lib/net/http.rb | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/lib/net/http.rb b/lib/net/http.rb index 7fd4c3ed..df69d428 100644 --- a/lib/net/http.rb +++ b/lib/net/http.rb @@ -1550,11 +1550,11 @@ def use_ssl=(flag) attr_accessor :cert_store # Sets or returns the available SSL ciphers. - # See {OpenSSL::SSL::SSLContext#ciphers=}[OpenSSL::SSL::SSL::Context#ciphers=]. + # See {OpenSSL::SSL::SSLContext#ciphers=}[https://docs.ruby-lang.org/en/master/OpenSSL/SSL/SSLContext.html#method-i-ciphers-3D]. attr_accessor :ciphers # Sets or returns the extra X509 certificates to be added to the certificate chain. - # See {OpenSSL::SSL::SSLContext#add_certificate}[OpenSSL::SSL::SSL::Context#add_certificate]. + # See {OpenSSL::SSL::SSLContext#add_certificate}[https://docs.ruby-lang.org/en/master/OpenSSL/SSL/SSLContext.html#method-i-add_certificate]. attr_accessor :extra_chain_cert # Sets or returns the OpenSSL::PKey::RSA or OpenSSL::PKey::DSA object. @@ -1564,15 +1564,15 @@ def use_ssl=(flag) attr_accessor :ssl_timeout # Sets or returns the SSL version. - # See {OpenSSL::SSL::SSLContext#ssl_version=}[OpenSSL::SSL::SSL::Context#ssl_version=]. + # See {OpenSSL::SSL::SSLContext#ssl_version=}[https://docs.ruby-lang.org/en/master/OpenSSL/SSL/SSLContext.html#method-i-ssl_version-3D]. attr_accessor :ssl_version # Sets or returns the minimum SSL version. - # See {OpenSSL::SSL::SSLContext#min_version=}[OpenSSL::SSL::SSL::Context#min_version=]. + # See {OpenSSL::SSL::SSLContext#min_version=}[https://docs.ruby-lang.org/en/master/OpenSSL/SSL/SSLContext.html#method-i-min_version-3D]. attr_accessor :min_version # Sets or returns the maximum SSL version. - # See {OpenSSL::SSL::SSLContext#max_version=}[OpenSSL::SSL::SSL::Context#max_version=]. + # See {OpenSSL::SSL::SSLContext#max_version=}[https://docs.ruby-lang.org/en/master/OpenSSL/SSL/SSLContext.html#method-i-max_version-3D]. attr_accessor :max_version # Sets or returns the callback for the server certification verification. @@ -1588,7 +1588,7 @@ def use_ssl=(flag) # Sets or returns whether to verify that the server certificate is valid # for the hostname. - # See {OpenSSL::SSL::SSLContext#verify_hostname=}[OpenSSL::SSL::SSL::Context#verify_hostname=]. + # See {OpenSSL::SSL::SSLContext#verify_hostname=}[https://docs.ruby-lang.org/en/master/OpenSSL/SSL/SSLContext.html#attribute-i-verify_hostname]. attr_accessor :verify_hostname # Returns the X509 certificate chain (an array of strings) From 0c2105cde64410a419f8b6b30e25ed26098a032a Mon Sep 17 00:00:00 2001 From: Hiroshi SHIBATA Date: Mon, 22 Jun 2026 13:26:39 +0900 Subject: [PATCH 2/2] Fix broken ENV link in proxy_from_env= doc RDoc parsed ENV['http_proxy'] inside the link label as a cross-reference, emitting a stray ENV and breaking the surrounding {label}[url] markup. Drop the subscript from the label. https://github.com/ruby/net-http/issues/292 Co-Authored-By: Claude Opus 4.8 --- lib/net/http.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/net/http.rb b/lib/net/http.rb index df69d428..a82de9d2 100644 --- a/lib/net/http.rb +++ b/lib/net/http.rb @@ -1304,7 +1304,7 @@ def response_body_encoding=(value) # Sets whether to determine the proxy from environment variable # 'ENV['http_proxy']'; - # see {Proxy Using ENV['http_proxy']}[rdoc-ref:Net::HTTP@Proxy+Using+ENVHTTPProxy]. + # see {Proxy Using ENV}[rdoc-ref:Net::HTTP@Proxy+Using+ENVHTTPProxy]. attr_writer :proxy_from_env # Sets the proxy address;