From 51fef665f89f210216ed33f4b55473fa943716c0 Mon Sep 17 00:00:00 2001 From: yashnevatia Date: Thu, 18 Jun 2026 10:35:37 +0100 Subject: [PATCH 1/4] adding debug logs --- chain_capabilities/aptos/actions/actions.go | 9 ++++++--- chain_capabilities/aptos/actions/write_report.go | 1 + 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/chain_capabilities/aptos/actions/actions.go b/chain_capabilities/aptos/actions/actions.go index f60978a8d..eccaa7bcc 100644 --- a/chain_capabilities/aptos/actions/actions.go +++ b/chain_capabilities/aptos/actions/actions.go @@ -71,10 +71,10 @@ func NewAptos(cfg *config.Config, p2pConfig map[string]string, aptosService type messageBuilder: messageBuilder, } - return a, a.initLimiters(limitsFactory) + return a, a.initLimiters(limitsFactory, lggr) } -func (a *Aptos) initLimiters(limitsFactory limits.Factory) (err error) { +func (a *Aptos) initLimiters(limitsFactory limits.Factory, lggr logger.Logger) (err error) { a.reportSizeLimit, err = limits.MakeUpperBoundLimiter(limitsFactory, cresettings.Default.PerWorkflow.ChainWrite.Aptos.ReportSizeLimit) if err != nil { return @@ -84,8 +84,11 @@ func (a *Aptos) initLimiters(limitsFactory limits.Factory) (err error) { if err != nil { return } - + lggr.Debugw("Initializing write report block timestamp active period limiter", "activePeriod", cresettings.Default.PerWorkflow.FeatureAptosWriteReportBlockTimestampActivePeriod) a.writeReportBlockTimestampActive, err = limits.MakeRangeLimiter(limitsFactory, cresettings.Default.PerWorkflow.FeatureAptosWriteReportBlockTimestampActivePeriod) + if err != nil { + return + } return } diff --git a/chain_capabilities/aptos/actions/write_report.go b/chain_capabilities/aptos/actions/write_report.go index b0582714f..fcfd8925e 100644 --- a/chain_capabilities/aptos/actions/write_report.go +++ b/chain_capabilities/aptos/actions/write_report.go @@ -432,6 +432,7 @@ func (wr *writeReport) getTxnInfoFromChain(ctx context.Context, txHash string) ( func (wr *writeReport) includeBlockTimestampInReply(ctx context.Context) bool { if wr.writeReportBlockTimestampActive == nil { + wr.lggr.Errorw("WriteReport block timestamp feature flag is nil") return false } if wr.executionTimestamp.IsZero() { From a3df2993dfc8270cc682c1ca96aa1539d854d05c Mon Sep 17 00:00:00 2001 From: yashnevatia Date: Thu, 18 Jun 2026 10:36:33 +0100 Subject: [PATCH 2/4] log --- chain_capabilities/aptos/actions/write_report.go | 1 + 1 file changed, 1 insertion(+) diff --git a/chain_capabilities/aptos/actions/write_report.go b/chain_capabilities/aptos/actions/write_report.go index fcfd8925e..679055093 100644 --- a/chain_capabilities/aptos/actions/write_report.go +++ b/chain_capabilities/aptos/actions/write_report.go @@ -438,6 +438,7 @@ func (wr *writeReport) includeBlockTimestampInReply(ctx context.Context) bool { if wr.executionTimestamp.IsZero() { wr.lggr.Errorw("ExecutionTimestamp is zero") } + wr.lggr.Debugw("Checking write report block timestamp active period", "executionTimestamp", wr.executionTimestamp) return wr.writeReportBlockTimestampActive.Check(ctx, commoncfg.NewTimestamp(wr.executionTimestamp)) == nil } From c6171810934f2e89a631ed653e4d109fa48d116f Mon Sep 17 00:00:00 2001 From: yashnevatia Date: Thu, 18 Jun 2026 14:14:50 +0100 Subject: [PATCH 3/4] use factory logger --- chain_capabilities/aptos/actions/actions.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/chain_capabilities/aptos/actions/actions.go b/chain_capabilities/aptos/actions/actions.go index eccaa7bcc..0de4f71c5 100644 --- a/chain_capabilities/aptos/actions/actions.go +++ b/chain_capabilities/aptos/actions/actions.go @@ -71,10 +71,10 @@ func NewAptos(cfg *config.Config, p2pConfig map[string]string, aptosService type messageBuilder: messageBuilder, } - return a, a.initLimiters(limitsFactory, lggr) + return a, a.initLimiters(limitsFactory) } -func (a *Aptos) initLimiters(limitsFactory limits.Factory, lggr logger.Logger) (err error) { +func (a *Aptos) initLimiters(limitsFactory limits.Factory) (err error) { a.reportSizeLimit, err = limits.MakeUpperBoundLimiter(limitsFactory, cresettings.Default.PerWorkflow.ChainWrite.Aptos.ReportSizeLimit) if err != nil { return @@ -84,7 +84,7 @@ func (a *Aptos) initLimiters(limitsFactory limits.Factory, lggr logger.Logger) ( if err != nil { return } - lggr.Debugw("Initializing write report block timestamp active period limiter", "activePeriod", cresettings.Default.PerWorkflow.FeatureAptosWriteReportBlockTimestampActivePeriod) + limitsFactory.Logger.Debugw("Initializing write report block timestamp active period limiter", "activePeriod", cresettings.Default.PerWorkflow.FeatureAptosWriteReportBlockTimestampActivePeriod) a.writeReportBlockTimestampActive, err = limits.MakeRangeLimiter(limitsFactory, cresettings.Default.PerWorkflow.FeatureAptosWriteReportBlockTimestampActivePeriod) if err != nil { return From b9a12e6c0b0634f7c75b169a150b1402857586b9 Mon Sep 17 00:00:00 2001 From: yashnevatia Date: Fri, 19 Jun 2026 11:47:21 +0100 Subject: [PATCH 4/4] log --- chain_capabilities/aptos/actions/actions.go | 6 +++--- chain_capabilities/aptos/actions/write_report_test.go | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/chain_capabilities/aptos/actions/actions.go b/chain_capabilities/aptos/actions/actions.go index 0de4f71c5..eccaa7bcc 100644 --- a/chain_capabilities/aptos/actions/actions.go +++ b/chain_capabilities/aptos/actions/actions.go @@ -71,10 +71,10 @@ func NewAptos(cfg *config.Config, p2pConfig map[string]string, aptosService type messageBuilder: messageBuilder, } - return a, a.initLimiters(limitsFactory) + return a, a.initLimiters(limitsFactory, lggr) } -func (a *Aptos) initLimiters(limitsFactory limits.Factory) (err error) { +func (a *Aptos) initLimiters(limitsFactory limits.Factory, lggr logger.Logger) (err error) { a.reportSizeLimit, err = limits.MakeUpperBoundLimiter(limitsFactory, cresettings.Default.PerWorkflow.ChainWrite.Aptos.ReportSizeLimit) if err != nil { return @@ -84,7 +84,7 @@ func (a *Aptos) initLimiters(limitsFactory limits.Factory) (err error) { if err != nil { return } - limitsFactory.Logger.Debugw("Initializing write report block timestamp active period limiter", "activePeriod", cresettings.Default.PerWorkflow.FeatureAptosWriteReportBlockTimestampActivePeriod) + lggr.Debugw("Initializing write report block timestamp active period limiter", "activePeriod", cresettings.Default.PerWorkflow.FeatureAptosWriteReportBlockTimestampActivePeriod) a.writeReportBlockTimestampActive, err = limits.MakeRangeLimiter(limitsFactory, cresettings.Default.PerWorkflow.FeatureAptosWriteReportBlockTimestampActivePeriod) if err != nil { return diff --git a/chain_capabilities/aptos/actions/write_report_test.go b/chain_capabilities/aptos/actions/write_report_test.go index d51788a53..f21bc9f93 100644 --- a/chain_capabilities/aptos/actions/write_report_test.go +++ b/chain_capabilities/aptos/actions/write_report_test.go @@ -97,7 +97,7 @@ func newTestHelper(t *testing.T) *testHelper { beholderProcessor: commontest.NopBeholderProcessor{}, messageBuilder: monitoring.NewMessageBuilder(types.ChainInfo{}, capabilities.CapabilityInfo{}, ""), } - require.NoError(t, a.initLimiters(limits.Factory{Logger: lggr})) + require.NoError(t, a.initLimiters(limits.Factory{Logger: lggr}, lggr)) enableWriteReportBlockTimestampFeatureFlag(a) return &testHelper{forwarderClient: mockClient, aptosService: mockService, aptos: a} } @@ -143,7 +143,7 @@ func newMultiNodeTestHelper(t *testing.T, transmissionIDStr string) (*testHelper beholderProcessor: commontest.NopBeholderProcessor{}, messageBuilder: monitoring.NewMessageBuilder(types.ChainInfo{}, capabilities.CapabilityInfo{}, ""), } - require.NoError(t, a.initLimiters(limits.Factory{Logger: lggr})) + require.NoError(t, a.initLimiters(limits.Factory{Logger: lggr}, lggr)) enableWriteReportBlockTimestampFeatureFlag(a) return &testHelper{forwarderClient: mockClient, aptosService: mockService, aptos: a}, node0Addr } @@ -694,7 +694,7 @@ func TestWriteReport_PreSubmissionCheck(t *testing.T) { beholderProcessor: commontest.NopBeholderProcessor{}, messageBuilder: monitoring.NewMessageBuilder(types.ChainInfo{}, capabilities.CapabilityInfo{}, ""), } - require.NoError(t, a.initLimiters(limits.Factory{Logger: lggr})) + require.NoError(t, a.initLimiters(limits.Factory{Logger: lggr}, lggr)) enableWriteReportBlockTimestampFeatureFlag(a) h := &testHelper{forwarderClient: mockClient, aptosService: mockService, aptos: a}