chore: upgrade ws to ^8.20.1 to address CVE-2026-45736#1286
Merged
Conversation
brendan-kellam
force-pushed
the
cursor/cve/ws
branch
from
84c53c8 to
e9641a2
Compare
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
WalkthroughThis PR adds a single changelog entry documenting an upgrade of the Changesws Dependency Upgrade Changelog Entry
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
License Audit❌ Status: FAIL
Fail Reasons
Unresolved Packages
Weak Copyleft Packages (informational)
Resolved Packages (10)
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@CHANGELOG.md`:
- Line 17: Move the CHANGELOG entry for PR `#1286` ("Upgraded `ws` to `^8.21.0`.
[`#1286`]") to the bottom of the "Fixed" section by relocating that single line so
it appears immediately after the entry for PR `#1149`; ensure the entry remains
unchanged except for its position and that the "Fixed" section ordering follows
the guideline of appending new entries at the bottom.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 61ad8a5e-c078-40ab-9185-2fc037f2ae9e
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (2)
CHANGELOG.mdpackage.json
brendan-kellam
force-pushed
the
cursor/cve/ws
branch
2 times, most recently
from
a5096dd to
33bb66c
Compare
brendan-kellam
changed the title
Refresh engine.io (6.6.4 -> 6.6.8) and socket.io-adapter (2.5.5 -> 2.5.7), whose existing socket.io ranges (~6.6.0, ~2.5.2) already admit versions that require a patched ws (~8.20.1). Consolidates every ws instance at 8.20.1 via a lockfile refresh only -- no resolutions override or package.json change. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
brendan-kellam
force-pushed
the
cursor/cve/ws
branch
from
33bb66c to
b365987
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes SOU-1171
Resolves CVE-2026-45736 (
wsuninitialized memory disclosure) by refreshing the stale socket.io subtree rather than forcing aresolutionsoverride.The vulnerable
ws@~8.17.1was pinned by two transitive packages whose parents' existing ranges already admitted patched versions:engine.io6.6.4 → 6.6.8 (ws ~8.20.1), within socket.io's~6.6.0socket.io-adapter2.5.5 → 2.5.7 (ws ~8.20.1), within socket.io's~2.5.2After
yarn up -R engine.io socket.io-adapter, everywsinstance consolidates at 8.20.1 (the fixed version). Lockfile-only change — nopackage.json/resolutionsoverride, per the CVE-fix playbook's preference for a refresh over a forced override.🤖 Generated with Claude Code
Summary by CodeRabbit