fix(webapp): stop favorites capturing pagination position in their URLs

Favoriting a paged view saved the cursor, direction, and page params,
so the favorite linked to a soon-stale slice of results, only lit up at
that exact cursor, and starring the same view from another page created
a duplicate. Saved and matched favorite URLs now drop the pagination
position via a shared canonicalizer, so a favorite pins the view's
filters and tabs, and paging within a favorited view keeps it active.
The span param stays: it pins a trace view selection that lives as long
as the favorited run page itself. Both sides of the match are
canonicalized so favorites saved before this keep working.

Author: samejr

apps/webapp/app/components/navigation/FavoritePageButton.tsx

@@ -11,10 +11,11 @@ import { useShortcuts } from "../primitives/ShortcutsProvider";
 import { SimpleTooltip } from "../primitives/Tooltip";
 import {
   buildFavoriteLabel,
+  canonicalFavoriteUrl,
   FAVORITE_SEARCH_PARAM,
   FAVORITES_ACTION_PATH,
+  favoritePageUrl,
   resolvePageMeta,
-  stripFavoriteSearchParam,
   useFavorites,
 } from "./favoritePages";
 
@@ -37,8 +38,9 @@ export function FavoritePageButton({
   const { areShortcutsEnabled } = useShortcuts();
   const [, setSearchParams] = useSearchParams();
 
-  // The favorite marker param is presentation-only, so it never counts toward URL identity
-  const url = location.pathname + stripFavoriteSearchParam(location.search);
+  // The marker param and pagination position never count toward URL identity, so paging through
+  // a favorited view keeps the same favorite (and never saves a soon-stale cursor)
+  const url = favoritePageUrl(location.pathname, location.search);
 
   // A marker that isn't one of this user's favorites came from a shared link (or a favorite
   // that's since been removed): clean it from the URL so the page behaves like a normal visit.
@@ -57,7 +59,7 @@ export function FavoritePageButton({
       { replace: true, preventScrollReset: true }
     );
   }, [hasForeignMarker, setSearchParams]);
-  const existing = favorites.find((favorite) => favorite.url === url);
+  const existing = favorites.find((favorite) => canonicalFavoriteUrl(favorite.url) === url);
   const isFavorited = existing !== undefined;
   // The tooltip names the favorite: its custom name once saved, else the label saving would use
   // (which includes detail-page ids and filter summaries, e.g. "Runs: Completed, last 7d")

apps/webapp/app/components/navigation/favoritePages.tsx

@@ -134,18 +134,36 @@ export function favoriteLinkTo(favorite: FavoritePage): string {
   return `${path}?${params.toString()}`;
 }
 
-/** The current location's search string without the favorite marker, for saving/matching URLs. */
-export function stripFavoriteSearchParam(search: string): string {
+/** Pagination position params: never part of a favorite's identity (see favoritePageUrl). */
+const PAGINATION_PARAMS = ["cursor", "direction", "page"];
+
+/**
+ * The canonical URL a favorite saves and matches against: the path and search minus the favorite
+ * marker (presentation-only) and the pagination position (cursors go stale, and page N of a view
+ * is not a different view). A favorite pins filters and tabs, never a transient page of them.
+ */
+export function favoritePageUrl(pathname: string, search: string): string {
   const params = new URLSearchParams(search);
   params.delete(FAVORITE_SEARCH_PARAM);
+  for (const param of PAGINATION_PARAMS) {
+    params.delete(param);
+  }
   const result = params.toString();
-  return result.length > 0 ? `?${result}` : "";
+  return pathname + (result.length > 0 ? `?${result}` : "");
+}
+
+/** favoritePageUrl for an already-joined URL, e.g. a favorite's stored one (which may predate
+ * pagination stripping). */
+export function canonicalFavoriteUrl(url: string): string {
+  const [pathname, search = ""] = url.split("?");
+  return favoritePageUrl(pathname, search);
 }
 
 /**
- * A favorite is active only while the URL is exactly the view it saved: its marker param is
- * present AND the rest of the URL still matches. Changing any filter on the page diverges the
- * URL from the favorite, so it deactivates (and the regular menu item takes over).
+ * A favorite is active only while the URL is the view it saved: its marker param is present AND
+ * the canonical URL still matches. Changing any filter on the page diverges the URL from the
+ * favorite, so it deactivates (and the regular menu item takes over) — but paging within the
+ * view keeps it active, matching what the favorite pins.
  */
 export function isFavoriteActive(
   favorite: FavoritePage,
@@ -154,7 +172,7 @@ export function isFavoriteActive(
 ): boolean {
   return (
     new URLSearchParams(search).get(FAVORITE_SEARCH_PARAM) === favorite.id &&
-    favorite.url === pathname + stripFavoriteSearchParam(search)
+    canonicalFavoriteUrl(favorite.url) === favoritePageUrl(pathname, search)
   );
 }
 
@@ -344,7 +362,7 @@ function humanizeValue(value: string): string {
 }
 
 /** Pagination/UI-state params that never describe what the user filtered. */
-const NON_FILTER_PARAMS = [FAVORITE_SEARCH_PARAM, "cursor", "direction", "page", "span"];
+const NON_FILTER_PARAMS = [FAVORITE_SEARCH_PARAM, ...PAGINATION_PARAMS, "span"];
 
 /**
  * Summarize a filtered view's search params into a short, selective descriptor for the favorite