Fix SFTP client states dropping unsent bytes after partial channel send#1008
Open
yosuke-wolfssl wants to merge 1 commit into
Open
Fix SFTP client states dropping unsent bytes after partial channel send#1008yosuke-wolfssl wants to merge 1 commit into
yosuke-wolfssl wants to merge 1 commit into
Conversation
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #1008
Scan targets checked: none
Failed targets: wolfssh-bugs, wolfssh-src
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Several SFTP client request states (read, write, open, mkdir, setstat, rename) advanced their state machine as soon as wolfSSH_SFTP_buffer_send() returned, without confirming the request bytes had actually left the client. Two cases were mishandled:
Additionally, wolfSSH_SFTP_Rename used a ret <= 0 guard that treated a WS_SUCCESS (0) flush-only resume as terminal, swallowing a subsequent server rejection and returning success.
Addressed by f_5574.
Changes