fix: include plasma in SUPPORTED_CHAINS#116
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #116 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 210 210
Branches 42 42
=========================================
Hits 210 210
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
084c517 to
9b53b5a
Compare
cgero-eth
approved these changes
Jul 1, 2026
Plasma was present in the SupportedChainId union, NATIVE_SYMBOL_BY_CHAIN_ID, and isChainIdSupported, but missing from SUPPORTED_CHAINS. That list is used to resolve the chain name when a transaction has reverted, so a reverted Plasma transaction logged an "undefined" chain name. Add plasma to the list to make the chain's declaration consistent across all four references.
9b53b5a to
07ec3f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
plasmais declared as a supported chain in three places — theSupportedChainIdunion (src/types.ts),NATIVE_SYMBOL_BY_CHAIN_ID, andisChainIdSupported(src/utils/index.ts) — but it is missing fromSUPPORTED_CHAINSinsrc/constants.ts.SUPPORTED_CHAINSis used inparseSwapto resolve the chain name when a transaction has reverted:For a reverted Plasma transaction this logs
... on undefined has reverted.even though the chain is otherwise fully supported.Solution
Add
plasmatoSUPPORTED_CHAINSso the chain is declared consistently across all four references.plasmais already imported inconstants.ts, so this is a one-line addition.Validation
tsc --emitDeclarationOnlypasses.