Skip to content

Vertical Lagrangian Remapping notes#39

Merged
chrisb13 merged 3 commits into
mainfrom
AG-Vertical-Lagrangian-Remapping
Jun 18, 2026
Merged

Vertical Lagrangian Remapping notes#39
chrisb13 merged 3 commits into
mainfrom
AG-Vertical-Lagrangian-Remapping

Conversation

@chrisb13

@chrisb13 chrisb13 commented Jun 5, 2026

Copy link
Copy Markdown
Collaborator

Please note @angus-g: 18/06/2026 you are presenting on Vertical Lagrangian Remapping for the decoding-om3 series.

This PR (entirely optional) is a placeholder for @angus-g to add Vertical Lagrangian Remapping notes.

FYI, happy to review things if useful but note that reviews on this repo' are optional.

@chrisb13 chrisb13 requested a review from angus-g June 5, 2026 07:21
@angus-g angus-g force-pushed the AG-Vertical-Lagrangian-Remapping branch 2 times, most recently from 9ba0331 to cbb0aed Compare June 16, 2026 07:10
@angus-g angus-g marked this pull request as ready for review June 16, 2026 07:12
@angus-g

angus-g commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

Thanks, I've put the structure of what I'd like to cover. Don't know if more/less detail or mathematics are desired!

@chrisb13

chrisb13 commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator Author

@atteggiani looks like we have similar failing checks here as here.

Comment thread documentation/docs/pages/season2.md Outdated
Comment thread documentation/docs/pages/season2.md Outdated
Comment thread documentation/docs/pages/season2.md
Comment thread documentation/docs/pages/season2.md
Comment thread documentation/docs/pages/season2.md Outdated
Comment thread documentation/docs/pages/season2.md

@chrisb13 chrisb13 left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @angus-g, looking good. I've made a few minor comments. Perhaps @AndyHoggANU would like to review too?

By the way, I made some main changes so this may need to be re-based before merging (you can ignore the failing checks).

@angus-g angus-g force-pushed the AG-Vertical-Lagrangian-Remapping branch from cbb0aed to 4e356e0 Compare June 17, 2026 07:16
@chrisb13

Copy link
Copy Markdown
Collaborator Author

Thanks @angus-g, let me know if you need an approval to merge or I can merge (as an admin) if you are happy?

@angus-g

angus-g commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator

Thanks @angus-g, let me know if you need an approval to merge or I can merge (as an admin) if you are happy?

I think I do:

Merging is blocked

New changes require approval from someone other than the last pusher.
Commits must have verified signatures.

@chrisb13

Copy link
Copy Markdown
Collaborator Author

H'm I think because I opened this I can't review it but I can just merge it. You okay for me to do a squash and merge @angus-g?

@chrisb13 chrisb13 merged commit b512951 into main Jun 18, 2026
1 check passed
@chrisb13 chrisb13 deleted the AG-Vertical-Lagrangian-Remapping branch June 18, 2026 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants