chore(ci): fix pre-existing fmt + clippy on main#20
Merged
Conversation
added 2 commits
June 11, 2026 16:16
main's CI was red from pre-existing issues unrelated to any open feature PR (even the docs-only PR failed them): cargo fmt drift in 6 files, plus two clippy -D warnings — manual char comparison in core/log.rs (use a char-array pattern) and an items-after-test-module in cri stats.rs (move the test module to the end). Greens `cargo fmt --all -- --check` and `cargo clippy --workspace --all-targets -- -D warnings` so the feature PRs can merge clean. No behavior change.
macOS clippy skipped the Linux-target guest-init code; CI (x86_64-linux) caught three more -D warnings: items-after-test-module in cgroup.rs (move test mod to end) and two manual_contains in main.rs (iter().any() → contains()).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
main's CI is red from pre-existing issues unrelated to any open feature PR — even the docs-only #17 fails them, in files no feature PR touched. This greens CI so the feature PRs (#15/#16/#18/#19) can merge clean.cargo fmt --all -- --check): drift in 6 files (cli/state/file.rs,core/log.rs,cri/service_ops.rs,runtime/oci/build/engine/handlers.rs,runtime/oci/layers.rs,shim/main.rs) — mechanicalcargo fmt.-D warnings):manual char comparisonincore/log.rs(→ char-array pattern['\n','\r']) anditems after a test moduleincri/.../stats.rs(→ move the test module to the end).No behavior change. Verified locally:
cargo fmt --all -- --checkclean,cargo clippy --workspace --all-targets -- -D warningsexit 0,a3s-box-core(400) +a3s-box-cri(237) unit tests pass.