Skip to content

fix(slnx): load Samples.Diagnostics as a project, excluded from solution build#189

Merged
ANcpLua merged 1 commit into
mainfrom
fix/slnx-diagnostics-project
Jul 7, 2026
Merged

fix(slnx): load Samples.Diagnostics as a project, excluded from solution build#189
ANcpLua merged 1 commit into
mainfrom
fix/slnx-diagnostics-project

Conversation

@ANcpLua

@ANcpLua ANcpLua commented Jul 7, 2026

Copy link
Copy Markdown
Owner

What

The Diagnostics sample had been added to ErrorOrX.slnx as loose <File> items (including its .csproj as a plain file), so IDEs loaded the files without any project context — no EOE analyzer/generator squiggles appeared. This replaces them with a proper <Project> entry excluded from the solution build:

<Project Path="samples/ErrorOrX.Samples.Diagnostics/ErrorOrX.Samples.Diagnostics.csproj">
    <Build Solution="*|*" Project="false" />
</Project>

The project now loads in the IDE for live diagnostics, while dotnet build ErrorOrX.slnx still skips it (its build fails by design — seven EOE diagnostics reported as errors). Also updates the Diagnostics README, which claimed the project was excluded from the slnx entirely.

Verification

  • dotnet build ErrorOrX.slnxBuild succeeded, 0 Warning(s), 0 Error(s)
  • dotnet build samples/ErrorOrX.Samples.Diagnostics/ → fails as intended, firing EOE003, EOE004, EOE006, EOE007, EOE020, EOE021, EOE024

Status: complete-and-verified. No package content changed — no release needed.

🤖 Generated with Claude Code

…ion build

The Diagnostics sample was added to ErrorOrX.slnx as loose <File> items
(including its .csproj), so IDEs showed the files without project context
and no EOE analyzer/generator squiggles appeared. Replace them with a
proper <Project> entry using <Build Solution="*|*" Project="false" />
so the project loads for IDE analysis but 'dotnet build ErrorOrX.slnx'
still skips it (its build fails by design — 7 EOE diagnostics as errors).

Verified: solution build green (0 warnings/0 errors); explicit project
build still fires EOE003/004/006/007/020/021/024.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (2)
  • ErrorOrX.slnx is excluded by none and included by none
  • samples/ErrorOrX.Samples.Diagnostics/README.md is excluded by none and included by none

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 1c9f2ee9-117e-484a-81cf-aaa53662d372

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@ANcpLua ANcpLua merged commit e9323dd into main Jul 7, 2026
6 checks passed
@ANcpLua ANcpLua deleted the fix/slnx-diagnostics-project branch July 7, 2026 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant