fix: remove pull_request trigger from deploy workflow#10
Merged
Conversation
PRs against main/master triggered a full build (pixi install, jekyll build, purgecss) for every commit, wasting CI minutes. The deploy step was already gated by a condition, but the pipeline still ran. Now deploy only runs on push to main/master or manual dispatch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the
pull_requesttrigger fromdeploy.yml.Why
The workflow was running on every PR commit — installing pixi, building the full site, purging CSS. The deploy step was gated with
if: github.event_name != 'pull_request'but the pipeline still ran, wasting ~3 minutes of CI per commit for no benefit.After
Deploy only runs on push to main/master or manual dispatch. PRs skip CI entirely for this workflow. Other PR checks (prettier, codeql, broken links, axe, lighthouse) still run independently.