Calculate irradiance#91
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for computing and visualizing the (Gaussian-model) normalized incident irradiance derived from previously estimated Moteki & Kondo parameters (τ and σ), and extends the existing incident-irradiance plot to include an irradiance overlay.
Changes:
- Added
compute_normalized_incident_irradiance_moteki_kondo()to compute (I(t)/I_0) fromtau_bestandsigma_hat. - Updated
plot_incident_irradiance()to plot a (scaled) incident-irradiance curve alongside the scattering signal. - Extended NDM tests to exercise the new irradiance computation and made small test tweaks in visualization tests.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
pysp2/util/normalized_derivative_method.py |
Adds the normalized irradiance computation helper and overlays the irradiance curve in the incident-irradiance plot. |
tests/test_ndm.py |
Adds test coverage that exercises the new normalized irradiance helper against an example waveform. |
tests/test_vis.py |
Minor tweaks to the visualization test setup (event selection comment/whitespace). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
rcjackson
reviewed
Jul 15, 2026
rcjackson
left a comment
Collaborator
There was a problem hiding this comment.
See my comments responding to copilot.
rcjackson
requested changes
Jul 16, 2026
rcjackson
left a comment
Collaborator
There was a problem hiding this comment.
I have two minor changes to request. Good job on this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: the scaling will have to be modified for evaporative particles. currently, the scaling is purely for visualization purposes.