Add Factory historian PR reviewer#193
Merged
Merged
Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
📝 WalkthroughWalkthroughAdds a repository-scoped maintainability historian reviewer with full-history evidence, read-only GitHub issue-tree delivery, charter guidance, manifest registration, verification procedures, contract tests, and README documentation. ChangesMaintainability reviewer
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant FactoryPR
participant MaintainabilityPersona
participant ReviewKit
participant GitHubIssueTree
FactoryPR->>MaintainabilityPersona: opened or synchronized PR event
MaintainabilityPersona->>ReviewKit: provide PR diff and full git history
ReviewKit->>GitHubIssueTree: deliver bounded advisory review
GitHubIssueTree-->>MaintainabilityPersona: retain one review for each head revision
Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.agentworkforce/agents/factory-maintainability/persona.test.ts:
- Around line 105-107: Extend the charter assertions in the persona test to
verify the bounded-output contract: require the verdict-first template, the
four-finding limit, and the 150-word maximum. Keep the existing title,
catalog-link, and “HoopSheet” assertions unchanged, and match the contract’s
established wording or patterns.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: a3e59d14-495c-4c3b-a490-bd1f3638e828
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (10)
.agentworkforce/agents/factory-feature-guardian/manifest-contract.test.ts.agentworkforce/agents/factory-maintainability/agent.ts.agentworkforce/agents/factory-maintainability/persona.json.agentworkforce/agents/factory-maintainability/persona.test.ts.agentworkforce/agents/factory-maintainability/persona.ts.agentworkforce/features/manifest.yaml.agentworkforce/features/verify/procedures.md.agentworkforce/workforce/personas/maintainability.mdREADME.mdpackage.json
Comment on lines
+105
to
+107
| expect(charter).toContain('# The Factory Maintainability Charter'); | ||
| expect(charter).toContain('.agentworkforce/features/critical-paths.md'); | ||
| expect(charter).not.toContain('HoopSheet'); |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win
Cover the charter’s bounded output contract.
The verification procedure requires the verdict-first, 150-word, four-finding contract, but this test only checks the title, catalog link, and absence of “HoopSheet.” Add assertions for the required verdict template and bounded-output rules.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.agentworkforce/agents/factory-maintainability/persona.test.ts around lines
105 - 107, Extend the charter assertions in the persona test to verify the
bounded-output contract: require the verdict-first template, the four-finding
limit, and the 150-word maximum. Keep the existing title, catalog-link, and
“HoopSheet” assertions unchanged, and match the contract’s established wording
or patterns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@agentworkforce/review-kitWhy
Factory's control-plane invariants are distributed across durable lifecycle code, provider boundaries, focused tests, the feature catalog, and the git history that established them. This reviewer gives each non-draft Factory PR a bounded maintainability review that recovers that history without editing or merging the checkout.
Validation
npx vitest run .agentworkforce/agents/factory-maintainability/persona.test.ts .agentworkforce/agents/factory-feature-guardian/manifest-contract.test.ts— 10 tests passednpm run featuremap:check— 25 categories / 301 features, no advisoriesnpm run buildnpm test— 166 suites and 1,321 tests passedCloses #180.