Skip to content

fix(agent): keep delayed Slack receipts retryable#196

Merged
khaliqgant merged 3 commits into
mainfrom
fix/feature-guardian-write-receipt-20260722-v2
Jul 22, 2026
Merged

fix(agent): keep delayed Slack receipts retryable#196
khaliqgant merged 3 commits into
mainfrom
fix/feature-guardian-write-receipt-20260722-v2

Conversation

@khaliqgant

@khaliqgant khaliqgant commented Jul 22, 2026

Copy link
Copy Markdown
Member

Summary

  • treat a successful Relayfile write with no provider timestamp as receipt-pending, not a terminal handler failure
  • leave the progress checkpoint unchanged so the next tick replays the existing stable idempotency key
  • cover late receipt replay and assert a single provider-side create in the idempotent transport

Root cause

The write helper can return after the draft is admitted but before the provider receipt is visible. The guardian previously translated that success-without-receipt state into Slack post failed: no timestamp returned for feature capabilities-register, even though provider completion could still arrive later.

Relayfile v0.10.36 fixes one underlying accepted-operation 404 receipt visibility defect, but it is not deployed to the running snapshot and it does not remove the helper independent 15-second receipt deadline. This PR fixes the residual agent-side classification bug in the duplicated Factory guardian.

Red / green

Runtime observed: Node v20.20.1, npm 10.8.2.

Red with the production branch restored at the no-timestamp branch and the final acceptance fixture: 1 failed, 35 passed; exact cause Slack post failed: no timestamp returned for feature capabilities-register at agent.ts:812.

Green at 7cd8e1f:

  • npx vitest run .agentworkforce/agents/factory-feature-guardian/agent.test.ts: 36 passed
  • npm run build: passed

No live agent run, deploy, merge, or production mutation was performed.

@cursor

cursor Bot commented Jul 22, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@khaliqgant, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 52 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 1e96172f-b17e-4181-bf4b-d75cb0ab845e

📥 Commits

Reviewing files that changed from the base of the PR and between ffd7146 and 7cd8e1f.

📒 Files selected for processing (2)
  • .agentworkforce/agents/factory-feature-guardian/agent.test.ts
  • .agentworkforce/agents/factory-feature-guardian/agent.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/feature-guardian-write-receipt-20260722-v2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@khaliqgant
khaliqgant merged commit 0724e2e into main Jul 22, 2026
7 checks passed
@khaliqgant
khaliqgant deleted the fix/feature-guardian-write-receipt-20260722-v2 branch July 22, 2026 15:27
@agent-relay-code

Copy link
Copy Markdown
Contributor

Verdict: Clean. Preserves the receiptless "do not advance the feature cycle" invariant (critical-paths.md:300) by converting a terminal throw into a non-advancing warn+return that replays the stable featurePostIdempotencyKey, with the rewritten delayed-receipt test asserting one provider create across two ticks.

maintainability review · .agentworkforce/workforce/personas/maintainability.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant