Fix/iplist blocklist scan perf 2#324
Closed
hansott wants to merge 2 commits into
Closed
Conversation
IPList.containsAddress() scanned every stored subnet/host linearly (O(n)). At 300k+ entries this costs ~13.7ms per lookup; isIpBlocked runs it up to 4x per request. Switched to inet.ipaddr's built-in DualIPv4v6Tries, giving O(bits) containment lookups (~1.2us at the same scale). Public API and matches() semantics unchanged; all existing IPListTest cases pass unmodified.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.