Skip to content

TPC: clamp zOut to TPC length #15519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matthias-kleiner wants to merge 2 commits into
base: dev
Choose a base branch
from
+5 −3
Open

TPC: clamp zOut to TPC length #15519

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ecb5f30
TPC: clamp zOut to TPC length
matthias-kleiner Jun 12, 2026
b292e3f
fix clang format
matthias-kleiner Jun 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions Detectors/TPC/calibration/SpacePoints/src/TrackResiduals.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,10 +133,12 @@ void TrackResiduals::setZ2XBinning(const std::vector<float>& binning)
mZ2XBinsDH.clear();
mZ2XBinsDI.clear();
mZ2XBinsCenter.clear();
const float maxZ2X = SpacePointsCalibConfParam::Instance().maxZ2X;
LOGP(info, "Using maxZ2X {} for setZ2XBinning", maxZ2X);
for (int iBin = 0; iBin < nBins; ++iBin) {
mZ2XBinsDH.push_back(.5f * (binning[iBin + 1] - binning[iBin]) * mMaxZ2X);
mZ2XBinsDH.push_back(.5f * (binning[iBin + 1] - binning[iBin]) * maxZ2X);
mZ2XBinsDI.push_back(.5f / mZ2XBinsDH[iBin]);
mZ2XBinsCenter.push_back(binning[iBin] * mMaxZ2X + mZ2XBinsDH[iBin]);
mZ2XBinsCenter.push_back(binning[iBin] * maxZ2X + mZ2XBinsDH[iBin]);
LOGF(info, "Bin %i: center (%.3f), half bin width (%.3f)", iBin, mZ2XBinsCenter.back(), mZ2XBinsDH.back());
}
}
Expand Down
2 changes: 1 addition & 1 deletion Detectors/TPC/calibration/src/TPCFastSpaceChargeCorrectionHelper.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -497,7 +497,7 @@ std::unique_ptr<o2::gpu::TPCFastSpaceChargeCorrection> TPCFastSpaceChargeCorrect
double yMax = rowX * trackResiduals.getY2X(iRow, trackResiduals.getNY2XBins() - 1);
double zMin = rowX * trackResiduals.getZ2X(0);
double zMax = rowX * trackResiduals.getZ2X(trackResiduals.getNZ2XBins() - 1);
double zOut = zMax;
double zOut = std::min(zMax, (double)geo.getTPCzLength()); // clamp to physical TPC extent to avoid negative spline scale
info.gridMeasured.set(yMin, spline.getGridX1().getUmax() / (yMax - yMin), // y
zMin, spline.getGridX2().getUmax() / (zMax - zMin), // z
zOut, geo.getTPCzLength()); // correction scaling region
Expand Down