Skip to content

[PWGDQ] add rematching task#16678

Merged
mcoquet642 merged 1 commit into
AliceO2Group:masterfrom
AliceMCH:PWGDQ-add-rematching-task
Jun 19, 2026
Merged

[PWGDQ] add rematching task#16678
mcoquet642 merged 1 commit into
AliceO2Group:masterfrom
AliceMCH:PWGDQ-add-rematching-task

Conversation

@aferrero2707

Copy link
Copy Markdown
Contributor

Add task to perform the following steps:

  • refit the MCH tracks with a custom alignment (optional)
  • apply alignment corrections to the MFT tracks (optional, no track refitting applied)
  • run a user-selected matching algorithm, based on chi2 or ML models
  • output the refitted and rematched tracks as FwdTracksReAlignand FwdTrksCovReAlign tables

@github-actions

github-actions Bot commented Jun 15, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 3 errors, ⚠️ 25 warnings, 🔕 6 disabled

mcoquet642 added a commit to AliceMCH/O2Physics that referenced this pull request Jun 18, 2026
Please consider the following formatting changes to AliceO2Group#16678
mcoquet642 added a commit to AliceMCH/O2Physics that referenced this pull request Jun 19, 2026
Please consider the following formatting changes to AliceO2Group#16678
@aferrero2707 aferrero2707 force-pushed the PWGDQ-add-rematching-task branch from 8fd40d7 to 3c35194 Compare June 19, 2026 12:16
@aferrero2707 aferrero2707 marked this pull request as ready for review June 19, 2026 13:54
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 3c35194 at 2026-06-19 16:03:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Tasks/global-muon-matcher.cxx:318:25: error: template constraint failure for 'template<class T>  requires  is_table<T> using o2::framework::Preslice = o2::framework::PresliceBase<T, o2::framework::PreslicePolicySorted, false>'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Tasks/global-muon-matcher.cxx:318:52: error: cannot convert 'const o2::framework::expressions::BindingNode' to 'int' in initialization
/sw/slc9_x86-64/O2/daily-20260619-0700-local1/include/Framework/StructToTuple.h:141:38: error: static assertion failed: You need to make sure that you have implicit constructors or that you call the explicit constructor correctly.
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Tasks/global-muon-matcher.cxx:1288:45: error: no matching function for call to 'o2::soa::Table<o2::aod::Hash<408887460>, o2::aod::Hash<3067181455>, o2::aod::Hash<2286545062> >::sliceBy(int&, int64_t) const'
/sw/slc9_x86-64/GCC-Toolchain/v14.2.0-alice2-1/include/c++/14.2.0/bits/stl_construct.h:115:28: error: no matching function for call to 'construct_at(GlobalMuonMatching*&)'
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for 3c35194 at 2026-06-19 16:04:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Tasks/global-muon-matcher.cxx:318:25: error: template constraint failure for 'template<class T>  requires  is_table<T> using o2::framework::Preslice = o2::framework::PresliceBase<T, o2::framework::PreslicePolicySorted, false>'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Tasks/global-muon-matcher.cxx:318:52: error: cannot convert 'const o2::framework::expressions::BindingNode' to 'int' in initialization
/sw/slc9_x86-64/O2/daily-20260619-0700-local1/include/Framework/StructToTuple.h:141:38: error: static assertion failed: You need to make sure that you have implicit constructors or that you call the explicit constructor correctly.
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Tasks/global-muon-matcher.cxx:1288:45: error: no matching function for call to 'o2::soa::Table<o2::aod::Hash<408887460>, o2::aod::Hash<3067181455>, o2::aod::Hash<2286545062> >::sliceBy(int&, int64_t) const'
/sw/slc9_x86-64/GCC-Toolchain/v14.2.0-alice2-1/include/c++/14.2.0/bits/stl_construct.h:115:28: error: no matching function for call to 'construct_at(GlobalMuonMatching*&)'
ninja: build stopped: subcommand failed.

Full log here.

@aferrero2707 aferrero2707 marked this pull request as draft June 19, 2026 14:06
The task allows to perform the following steps:
- refit the muon tracks based on a custom geometry file (realignment)
- apply global angular and position corrections to the MFT track
- redo the MFT-MCH matching with the updated track parameters and various
choiches of the matching method, either based on chi2 or machine learning
models
@aferrero2707 aferrero2707 force-pushed the PWGDQ-add-rematching-task branch from 3c35194 to 48cf90b Compare June 19, 2026 14:41
@aferrero2707 aferrero2707 marked this pull request as ready for review June 19, 2026 14:41
@vkucera

vkucera commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator

@aferrero2707 Your branch is 3 weeks behind the upstream and missing several DQ PRs. Are you sure your PR works fine with the current master?

@aferrero2707

aferrero2707 commented Jun 19, 2026

Copy link
Copy Markdown
Contributor Author

@vkucera I just double-checked and I do not see any merged PR that would be relevant for the code introduced here, except one that I tested extensively (see #16700). The new rematching task is actually quite self-contained, and supposed to run upstream of most DQ tools.

@mcoquet642

Copy link
Copy Markdown
Collaborator

@vkucera compiled and tested it with latest O2Physics tag, everything works. Merging

@mcoquet642 mcoquet642 merged commit 2ce9cc8 into AliceO2Group:master Jun 19, 2026
11 of 13 checks passed
@vkucera

vkucera commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator

Please fix the introduced errors and warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

4 participants