Turn system.replicated_partition_exports table into a history table by removing the TTL#1917
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e8bf8f243d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| json.set("create_time", create_time); | ||
| json.set("max_retries", max_retries); | ||
| json.set("ttl_seconds", ttl_seconds); | ||
| json.set("task_timeout_seconds", task_timeout_seconds); |
There was a problem hiding this comment.
ttl_seconds in exported manifests
During a rolling upgrade, a newly upgraded replica will now create /exports/.../metadata.json without ttl_seconds, but any still-running pre-change replica deserializes every export manifest with json->getValue<size_t>("ttl_seconds") in ExportReplicatedMergeTreePartitionManifest::fromJsonString. That makes those replicas throw an exception while polling/scheduling/displaying/killing the export, so mixed-version clusters can leave newly created exports unprocessed or invisible until every replica is upgraded. Please keep writing a dummy ttl_seconds field for the compatibility window while ignoring it in the new code.
Useful? React with 👍 / 👎.
arthurpassos
added
antalya
port-antalya
3 participants
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Turn system.replicated_partition_exports table into a history table by removing the TTL. CLoses #1281
Documentation entry for user-facing changes
...
CI/CD Options
Exclude tests:
Regression jobs to run: