Skip to content

Antalya 26.3: Iceberg client, handle namespaceExists error#1918

Open
subkanthi wants to merge 5 commits into
antalya-26.3from
1907-create-iceberg-table-takes-too-long
Open

Antalya 26.3: Iceberg client, handle namespaceExists error#1918
subkanthi wants to merge 5 commits into
antalya-26.3from
1907-create-iceberg-table-takes-too-long

Conversation

@subkanthi

@subkanthi subkanthi commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

  • Fix slowness in Create Table Iceberg Engine where namespaceExists error is not handed and CH retries multiple times.

Documentation entry for user-facing changes

CI/CD Options

Exclude tests:

  • Fast test
  • Integration Tests
  • Stateless tests
  • Stateful tests
  • Performance tests
  • All with ASAN
  • All with TSAN
  • All with MSAN
  • All with UBSAN
  • All with Coverage
  • All with Aarch64
  • All Regression
  • Disable CI Cache

Regression jobs to run:

  • Fast suites (mostly <1h)
  • Aggregate Functions (2h)
  • Alter (1.5h)
  • Benchmark (30m)
  • ClickHouse Keeper (1h)
  • Iceberg (2h)
  • LDAP (1h)
  • OAuth (5m)
  • Parquet (1.5h)
  • RBAC (1.5h)
  • SSL Server (1h)
  • S3 (2h)
  • S3 Export (2h)
  • Swarms (30m)
  • Tiered Storage (2h)

@subkanthi subkanthi linked an issue Jun 16, 2026 that may be closed by this pull request
@github-actions

github-actions Bot commented Jun 16, 2026

Copy link
Copy Markdown

Workflow [PR], commit [c726c3f]

@subkanthi subkanthi closed this Jun 17, 2026
@subkanthi subkanthi reopened this Jun 17, 2026
@subkanthi subkanthi marked this pull request as ready for review June 18, 2026 20:23
@subkanthi subkanthi changed the title Added handling of 409 namespacealreadyexists in createNamespaceIfNotE… Antalya 26.3: Iceberg client, handle namespaceExists error Jun 18, 2026
auto timer = DB::CurrentThread::getProfileEvents().timer(ProfileEvents::DataLakeRestCatalogCreateNamespaceMicroseconds);
sendRequest(endpoint, request_body);
DB::ReadSettings read_settings = getContext()->getReadSettings();
read_settings.http_max_tries = 1;

@subkanthi subkanthi Jun 18, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couldnt find a better way to stop retrying as the retries happen in sendRequest, adding to nonRetriable error codes will affect all http calls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create iceberg table takes too long

2 participants