feat(mobile): show full setting descriptions - #187
Draft
Lint111 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Let phone users open the full description of an App Settings option without toggling or editing that option.
Compact mobile setting tiles truncate long explanations. This adds an accessible bottom-sheet description layer while leaving the existing controls and desktop title tooltips unchanged.
Behavior
Accessibility
role="dialog"andaria-modal="true"on the description panel.role="button",tabindex,aria-haspopup, andaria-controls.Scope Correction
The original test referenced the terminal-controls setting from another feature branch. This split uses the existing upstream Wheel Scrolls Local History setting instead, so the PR targets
masterindependently.Verification
npx vitest run --config test/mobile/vitest.config.ts test/mobile/settings.test.ts -t "opens the full option description"origin/master:mobile defaults: all panels hidden, subagent tracking OFF, ralph OFFsettings survive page reloadnpx prettier --check test/mobile/settings.test.tsnpm run check:frontend-syntaxnpm run check:public-assetsnpm run buildNon-Goals