feat: add trip summary panel#745
Conversation
Introduce a shared TripSummaryPanel rendering the route map plus a summary card with price, total travel time and total walk distance. The details body now uses it in place of the map + duration/walk-distance overlay, so the details view also shows the trip price. Add a 'summary' variant to the Price component (rendering a SummaryRow) and the split label/value translations it needs.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
strandlie
changed the title
strandlie
force-pushed
the
strandlie/trip-detail-summary
branch
from
80cfcb2 to
04fdec6
Compare
rosvik
left a comment
rosvik
left a comment
There was a problem hiding this comment.
Noticed a few things here:
- There are a bunch of comments added here that I don't think adds much. Could you have a look through and remove the ones you don't think are necessary?
- There is a lot of extra padding in the mobile layout:
| flex-direction: column; | ||
| gap: token('spacing.medium'); | ||
| padding: token('spacing.large'); | ||
| border: 1px solid token('color.background.neutral.1.background'); |
There was a problem hiding this comment.
On the trip details page, this border is the same color as the background - is that by design? I'm noticing that it appears in the transition between light and dark mode, which looks a bit strange.
There was a problem hiding this comment.
If not by design, its on purpose. Generally the summary panel looks a little weird on the details page now, since it has the same color as the background and no border. But that will be fixed with the travel-card introduction that is coming soon.
The priceLabel translation line exceeded prettier's print width, failing the tsc/check-all CI job. Reflow it across multiple lines.
strandlie
force-pushed
the
strandlie/trip-detail-summary
branch
from
eea100c to
f0a07bf
Compare
|
@rosvik Ended up changing, removing and simplifying a lot here. Great if you could take another look now. |
2 participants
Next step of https://github.com/AtB-AS/kundevendt/issues/23752
Figma
Improvements to the trip-detail view, to make TPW ready for the new Trip Card
Screenshots
Changes
TripSummaryPanel: route map + a summary card with price, total travel time and total walk distance. The details body now uses it instead of the map + duration/walk-distance overlay, so the details page also shows the trip price.Pricegains asummaryvariant (renders aSummaryRow), plus the split label/value translations it needs.TripRowlabelAlignoption; the label column is tightened.