feat!: remove fallback and signing keys from pxe#24451
Merged
nventuro merged 2 commits intoJul 2, 2026
Merged
Conversation
Cheetah0x
reviewed
Jul 2, 2026
mverzilli
reviewed
Jul 2, 2026
mverzilli
approved these changes
Jul 2, 2026
mverzilli
left a comment
mverzilli
left a comment
Contributor
There was a problem hiding this comment.
Looks good, I'd suggest to do the little refactor I pointed out in KeyStore but up to you
Collaborator
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
nventuro
deleted the
nico/f-777-remove-fallback-and-message-signing-keys-from-pxe
branch
vezenovm
added a commit
that referenced
this pull request
Jul 2, 2026
…ice test Semantic conflict with #24451 from the fairies-v5 merge: addAccount now takes AccountPrivacyKeys instead of a secret-key Fr.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up of #24416. With this, PXE no longer has access to the message signing key nor the fallback keys, as should be (since the semantics of those keys require user approval before usage).
To keep things simple, I removed the option of passing a seed from which all keys are derived to PXE and made it so the wallet must pass the privacy keys plus the message signing and fallback public keys. The wallet does derive these from a seed, but that's a decision the wallet makes, PXE doesn't force it.