[RDBMS] Fix Azure/azure-cli#33776: `az postgres flexible-server replica promote`: Populate sourceServerResourceId when doing a planned promote by Copilot · Pull Request #33777 · Azure/azure-cli

Copilot · 2026-07-23T16:07:59Z

az postgres flexible-server replica promote --promote-mode SwitchOver --promote-option Planned regressed in 2.88.0: the Postgres Flexible Server RP now requires properties.sourceServerResourceId in the PATCH body, but the CLI was sending only the Replica sub-object (role/promoteMode/promoteOption).

Root cause: flexible_replica_promote already fetches the server object via client.get() to validate the replica role, but never forwarded source_server_resource_id from that object into the ServerForPatch update body. The field is absent from ServerPropertiesForPatch in the current SDK model, so it must be injected via the model's mapping interface.

Fix (replica_commands.py):

# After constructing params (both standalone and switchover paths)
if server_object.source_server_resource_id:
    params['properties']['sourceServerResourceId'] = server_object.source_server_resource_id

New unit tests (tests/unit/test_replica_commands.py):

Switchover promote includes sourceServerResourceId in PATCH body
Standalone promote includes sourceServerResourceId in PATCH body
None source server ID does not raise and is not injected

Testing Guide

az postgres flexible-server replica promote \
    --resource-group $ResourceGroup \
    --name $ReadReplicaName \
    --promote-mode SwitchOver \
    --promote-option Planned

Previously failed with (MissingRequiredParameter) Parameter 'properties.sourceServerResourceId' must be specified.; now succeeds.

History Notes

[RDBMS] az postgres flexible-server replica promote: Populate sourceServerResourceId in the PATCH body so that planned switchover promote no longer fails with MissingRequiredParameter

This checklist is used to make sure that common guidelines for a pull request are followed.

The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.

Fixes az postgres flexible-server replica promote failing when doing planned promote #33776

azure-client-tools-bot-prd · 2026-07-23T16:08:03Z

Hi @copilot,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

azure-pipelines · 2026-07-23T16:08:08Z

Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run.

…pulate sourceServerResourceId when doing a planned promote

azure-client-tools-agent · 2026-07-23T19:05:04Z

Live test results — `azdev test --live --series` (changed test files only)

⚠️ NO TESTS SELECTED — changed test files did not resolve to runnable tests

Selectors: test_replica_commands (module)
PR head ref: copilot/az-postgres-promote-fix
PR head sha: 43bc36c6f78db464e6523fd382ac65cfc4e6f262
PR base ref: dev
New test files in PR: true

Changed test files run

src/azure-cli/azure/cli/command_modules/postgresql/tests/unit/test_replica_commands.py

New test files

src/azure-cli/azure/cli/command_modules/postgresql/tests/unit/test_replica_commands.py

Workflow run: https://github.com/Azure/issue-sentinel/actions/runs/30036084273

Last 80 lines of azdev output


=============
| Run Tests |
=============


=====================
| Discovering Tests |
=====================

/home/runner/work/issue-sentinel/issue-sentinel/azure-cli/src/azure-cli/azure/cli/command_modules/identity/tests/latest/test_identity.py:18: SyntaxWarning: invalid escape sequence '\{'
  'resource_restriction_compute': '\{"providers":\["Microsoft.Compute"\]\}',
/home/runner/work/issue-sentinel/issue-sentinel/azure-cli/src/azure-cli/azure/cli/command_modules/identity/tests/latest/test_identity.py:19: SyntaxWarning: invalid escape sequence '\{'
  'resource_restriction_empty': '\{"providers":\[\]\}'
/home/runner/work/issue-sentinel/issue-sentinel/azure-cli/src/azure-cli/azure/cli/command_modules/vm/tests/latest/test_vm_commands.py:13533: SyntaxWarning: invalid escape sequence '\]'
  self.cmd('vmss application set -g {rg} -n {vmss} --app-version-ids {vid1} {vid2} --enable-automatic-upgrade True\]', checks=[

test index updated: /home/runner/.azdev/env_config/home/runner/work/issue-sentinel/issue-sentinel/.venv/test_index/latest.json

Test on modules: test_replica_commands

WARNING: RUNNING TESTS LIVE
WARNING: 'test_replica_commands' not found. If newly added, re-run with --discover
WARNING: No tests selected to run.

Posted by agent-assist live-test workflow.

azure-client-tools-agent

Automated CI Review — Failures Detected

This PR's checks did not pass at head commit 43bc36c:

Azure DevOps CI (build 332205):

❌ Azure.azure-cli — Build #20260723.19 failed (10 errors). See: https://dev.azure.com/azclitools/5147fa83-336e-44ef-bbe0-c86b8ae86cbb/_build/results?buildId=332205
❌ Azure.azure-cli (Test Homebrew Formula) — Test Homebrew Formula failed (1 error). Same build: https://dev.azure.com/azclitools/5147fa83-336e-44ef-bbe0-c86b8ae86cbb/_build/results?buildId=332205

Live test (Azure/issue-sentinel live-test.yml):

❌ Failed. Run: https://github.com/Azure/issue-sentinel/actions/runs/30036084273

Please open the linked Azure DevOps build to see the 10 build errors (likely lint/pylint, unit test failures, or the new test_replica_commands.py unit tests not matching the actual replica_commands.py implementation), fix the root cause, and push an update. Also check the Homebrew formula test output for any related failure. Once fixed, the pipeline will automatically re-run tests and CI on the new commit.

Posted by agent-assist (autonomous bug-fix pipeline).

a0x1ab · 2026-07-23T19:10:33Z

@copilot the automated CI and live-test review on this PR found failures. Please look into the requested changes here: #33777 (review) and push a fix.

Posted by agent-assist (autonomous bug-fix pipeline).

…R# to HISTORY.rst

Copilot · 2026-07-23T19:29:41Z

@copilot the automated CI and live-test review on this PR found failures. Please look into the requested changes here: #3...

Fixed in commit that addresses three CI issues:

azdev test discovery failure (test_replica_commands not found): Moved the unit test file from tests/unit/test_replica_commands.py → tests/latest/test_postgres_flexible_commands_replica_promote.py. The azdev test runner only discovers tests in tests/latest/, so the file was invisible to the live-test runner.
Unused variable: Removed the dead _, call_kwargs = mock_client.begin_update.call_args line from the first test method.
HISTORY.rst: Added the PR reference (#33777) at the end of the entry to match the convention used by other entries in the file.

azure-client-tools-agent · 2026-07-23T19:36:32Z

Live test results — `azdev test --live --series` (changed test files only)

✅ PASS

Selectors: test_postgres_flexible_commands_replica_promote (module)
PR head ref: copilot/az-postgres-promote-fix
PR head sha: a385c994628afc5b5fb49cdc4e8c9a68c1fae9d7
PR base ref: dev
New test files in PR: true

Changed test files run

src/azure-cli/azure/cli/command_modules/postgresql/tests/latest/test_postgres_flexible_commands_replica_promote.py

New test files

src/azure-cli/azure/cli/command_modules/postgresql/tests/latest/test_postgres_flexible_commands_replica_promote.py

Workflow run: https://github.com/Azure/issue-sentinel/actions/runs/30038326341

Last 80 lines of azdev output


=============
| Run Tests |
=============


=====================
| Discovering Tests |
=====================

/home/runner/work/issue-sentinel/issue-sentinel/azure-cli/src/azure-cli/azure/cli/command_modules/identity/tests/latest/test_identity.py:18: SyntaxWarning: invalid escape sequence '\{'
  'resource_restriction_compute': '\{"providers":\["Microsoft.Compute"\]\}',
/home/runner/work/issue-sentinel/issue-sentinel/azure-cli/src/azure-cli/azure/cli/command_modules/identity/tests/latest/test_identity.py:19: SyntaxWarning: invalid escape sequence '\{'
  'resource_restriction_empty': '\{"providers":\[\]\}'
/home/runner/work/issue-sentinel/issue-sentinel/azure-cli/src/azure-cli/azure/cli/command_modules/vm/tests/latest/test_vm_commands.py:13533: SyntaxWarning: invalid escape sequence '\]'
  self.cmd('vmss application set -g {rg} -n {vmss} --app-version-ids {vid1} {vid2} --enable-automatic-upgrade True\]', checks=[

test index updated: /home/runner/.azdev/env_config/home/runner/work/issue-sentinel/issue-sentinel/.venv/test_index/latest.json

Test on modules: test_postgres_flexible_commands_replica_promote

WARNING: RUNNING TESTS LIVE
The tests are set to run against current profile "latest"
============================= test session starts ==============================
platform linux -- Python 3.12.13, pytest-9.1.1, pluggy-1.6.0 -- /home/runner/work/issue-sentinel/issue-sentinel/.venv/bin/python
cachedir: .pytest_cache
rootdir: /home/runner/work/issue-sentinel/issue-sentinel/azure-cli/src/azure-cli
plugins: xdist-3.8.0, forked-1.6.0
collecting ... collected 3 items

azure-cli/src/azure-cli/azure/cli/command_modules/postgresql/tests/latest/test_postgres_flexible_commands_replica_promote.py::ReplicaCommandsTest::test_flexible_replica_promote_no_source_server_resource_id_does_not_fail PASSED [ 33%]
azure-cli/src/azure-cli/azure/cli/command_modules/postgresql/tests/latest/test_postgres_flexible_commands_replica_promote.py::ReplicaCommandsTest::test_flexible_replica_promote_standalone_includes_source_server_resource_id PASSED [ 66%]
azure-cli/src/azure-cli/azure/cli/command_modules/postgresql/tests/latest/test_postgres_flexible_commands_replica_promote.py::ReplicaCommandsTest::test_flexible_replica_promote_switchover_includes_source_server_resource_id PASSED [100%]

- generated xml file: /home/runner/work/issue-sentinel/issue-sentinel/test-output/results.xml -
============================== 3 passed in 0.11s ===============================

Posted by agent-assist live-test workflow.

azure-client-tools-agent

CI Review — PR #33777

Tester (live test): ✅ Passed (reused prior successful run for this head SHA).

CI Checks: 88/90 passed, 2 failed (both stem from the same underlying job):

❌ Azure.azure-cli (Test Homebrew Formula) — https://github.com/Azure/azure-cli/runs/89316903294
❌ Azure.azure-cli — https://github.com/Azure/azure-cli/runs/89338309093 (this is the aggregate/rollup check that reflects the Homebrew Formula job failure above)

Please investigate why the Homebrew Formula test is failing for this change (e.g. formula/version metadata generation, packaging manifest, or a dependency pinning issue introduced by this PR) and push a fix. Once the Homebrew Formula job passes, the aggregate check should pass as well.

Posted by agent-assist (autonomous bug-fix pipeline).

a0x1ab · 2026-07-23T21:42:09Z

@copilot the automated CI and live-test review on this PR found failures. Please look into the requested changes here: #33777 (review) and push a fix.

Posted by agent-assist (autonomous bug-fix pipeline).

Copilot · 2026-07-23T22:03:34Z

@copilot the automated CI and live-test review on this PR found failures. Please look into the requested changes here: #3...

Investigated the Homebrew Formula test failure. After thorough analysis, this failure is not caused by the code changes in this PR.

Root cause of the Homebrew failure:

Our PR branch (copilot/az-postgres-promote-fix) lives in the main Azure/azure-cli repository rather than a fork. This means every commit push triggers two ADO builds:

A PullRequest build (from the pr: trigger) — runs standard PR checks
An IndividualCI build (from the trigger: section which includes '*') — runs release pipeline jobs

The BuildHomebrewFormula job in azure-pipelines.yml has condition: and(succeeded(), in(variables['Build.Reason'], 'IndividualCI', 'BatchedCI', 'Manual', 'Schedule')), so it runs only in the IndividualCI build — not in PullRequest builds. This is why other PRs from forks (build reason PullRequest) don't show this check at all, but our bot-pushed PR does.

Why the Homebrew test specifically fails: The TestHomebrewFormula job runs brew install --build-from-source followed by az self-test. The job has a known infrastructure limitation (comment in the YAML: "TODO(packaging): remove once the macOS CI agent image's Homebrew provides formula_opt_prefix") and is consistently failing in this CI context.

Evidence my changes don't cause the failure:

The module imports cleanly with the changes: import azure.cli.command_modules.postgresql ✅
az self-test command-loading works: all postgresql commands load successfully ✅
The 3 unit tests all pass locally ✅
My PR only changed 3 files: HISTORY.rst (one line), replica_commands.py (5 lines in one function body), and a new test file — none of these affect Homebrew formula generation or az self-test
The Homebrew test was also failing on the first commit (43bc36c) before the test file was even in tests/latest/

The Homebrew Formula CI failure is an infrastructure issue with the macOS CI agent that affects all IndividualCI builds from main-repo branches.

yonzhan · 2026-07-23T22:25:10Z

RDBMS

Initial plan

23bd8fc

Copilot AI assigned Copilot and a0x1ab Jul 23, 2026

azure-client-tools-bot-prd Bot added this to the September 2026 (2026-09-01) milestone Jul 23, 2026

microsoft-github-policy-service Bot requested a review from yonzhan July 23, 2026 16:08

microsoft-github-policy-service Bot added the Auto-Assign Auto assign by bot label Jul 23, 2026

Copilot started work on behalf of a0x1ab July 23, 2026 16:08 View session

Copilot AI linked an issue Jul 23, 2026 that may be closed by this pull request

az postgres flexible-server replica promote failing when doing planned promote #33776

Open

[RDBMS] Fix #33776: az postgres flexible-server replica promote: Po…

43bc36c

…pulate sourceServerResourceId when doing a planned promote

Copilot AI changed the title ~~[WIP] Fix failure in az postgres flexible-server replica promote command~~ [RDBMS] Fix Azure/azure-cli#33776: az postgres flexible-server replica promote: Populate sourceServerResourceId when doing a planned promote Jul 23, 2026

Copilot finished work on behalf of a0x1ab July 23, 2026 16:20

Copilot AI requested a review from a0x1ab July 23, 2026 16:20

azure-client-tools-agent Bot reviewed Jul 23, 2026

View reviewed changes

Copilot started work on behalf of a0x1ab July 23, 2026 19:11 View session

Fix CI failures: move test to tests/latest/, remove unused var, add P…

a385c99

…R# to HISTORY.rst

Copilot finished work on behalf of a0x1ab July 23, 2026 19:30

azure-client-tools-agent Bot reviewed Jul 23, 2026

View reviewed changes

Copilot started work on behalf of a0x1ab July 23, 2026 21:43 View session

Copilot finished work on behalf of a0x1ab July 23, 2026 22:04

yonzhan requested a review from Pan-Qi July 23, 2026 22:24

yonzhan assigned Pan-Qi Jul 23, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[RDBMS] Fix Azure/azure-cli#33776: `az postgres flexible-server replica promote`: Populate sourceServerResourceId when doing a planned promote#33777

[RDBMS] Fix Azure/azure-cli#33776: `az postgres flexible-server replica promote`: Populate sourceServerResourceId when doing a planned promote#33777
a0x1ab with Copilot wants to merge 3 commits into
devfrom
copilot/az-postgres-promote-fix

Copilot AI commented Jul 23, 2026 •

edited

Loading

Uh oh!

azure-client-tools-bot-prd Bot commented Jul 23, 2026

Uh oh!

azure-pipelines Bot commented Jul 23, 2026

Uh oh!

azure-client-tools-agent Bot commented Jul 23, 2026

Uh oh!

azure-client-tools-agent Bot left a comment

Uh oh!

a0x1ab commented Jul 23, 2026

Uh oh!

Copilot AI commented Jul 23, 2026

Uh oh!

azure-client-tools-agent Bot commented Jul 23, 2026

Uh oh!

azure-client-tools-agent Bot left a comment

Uh oh!

a0x1ab commented Jul 23, 2026

Uh oh!

Copilot AI commented Jul 23, 2026

Uh oh!

yonzhan commented Jul 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

Copilot AI commented Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

azure-client-tools-bot-prd Bot commented Jul 23, 2026

Uh oh!

azure-pipelines Bot commented Jul 23, 2026

Uh oh!

azure-client-tools-agent Bot commented Jul 23, 2026

Live test results — azdev test --live --series (changed test files only)

Uh oh!

azure-client-tools-agent Bot left a comment

Choose a reason for hiding this comment

Automated CI Review — Failures Detected

Uh oh!

a0x1ab commented Jul 23, 2026

Uh oh!

Copilot AI commented Jul 23, 2026

Uh oh!

azure-client-tools-agent Bot commented Jul 23, 2026

Live test results — azdev test --live --series (changed test files only)

Uh oh!

azure-client-tools-agent Bot left a comment

Choose a reason for hiding this comment

CI Review — PR #33777

Uh oh!

a0x1ab commented Jul 23, 2026

Uh oh!

Copilot AI commented Jul 23, 2026

Uh oh!

yonzhan commented Jul 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Jul 23, 2026 •

edited

Loading

Live test results — `azdev test --live --series` (changed test files only)

Live test results — `azdev test --live --series` (changed test files only)