Skip to content

Updated navbar to latest design.#625

Merged
Randy808 merged 1 commit into
Blockstream:masterfrom
Randy808:nav-update-20260609
Jun 16, 2026
Merged

Updated navbar to latest design.#625
Randy808 merged 1 commit into
Blockstream:masterfrom
Randy808:nav-update-20260609

Conversation

@Randy808

@Randy808 Randy808 commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

To run locally, npm install and use the following snippets:

# Bitcoin
export API_URL=https://blockstream.info/api
export PORT=4999
source flavors/blockstream/config.env
source flavors/bitcoin-mainnet/config.env
npm run dev-server
# Liquid
export API_URL=https://blockstream.info/liquid/api
export PORT=5000
source flavors/blockstream/config.env
source flavors/liquid-mainnet/config.env
npm run dev-server

Bitcoin theme on Chrome (desktop):

chrome desktop | btc

Bitcoin theme on Chrome (mobile):

chrome mobile | btc

Liquid theme on Chrome (desktop):

chrome desktop | lbtc

Bitcoin theme on Firefox (desktop):

firefox desktop | btc

Bitcoin theme on Firefox (mobile):

firefox mobile | btc

@Randy808 Randy808 force-pushed the nav-update-20260609 branch from 5d92cb8 to a7ca465 Compare June 9, 2026 15:51
@Randy808 Randy808 self-assigned this Jun 9, 2026
@Randy808 Randy808 marked this pull request as ready for review June 9, 2026 15:52
@Randy808

Randy808 commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator Author

- [ ] Fix logo in light mode

EDIT: Product said to remove light mode so this action item is no longer applicable

@Randy808

Copy link
Copy Markdown
Collaborator Author

I'm going to move this back to draft since I want #627 to get merged first

@Randy808 Randy808 marked this pull request as draft June 10, 2026 17:58
@FedOken

FedOken commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator
image I think this could be attributed to this MR. It's up to you. It seems to me that the trigger area for opening the menu is quite large, you can try it locally, it opens unexpectedly before you actually hover over icon.

@FedOken

FedOken commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator
image For assets page, there are no gap between navbar and the page content

Are you planning to fix this in another PR?

Comment thread client/src/app.js
if (e.key == 'Escape') closeNetworkMenus()
if ((e.metaKey || e.ctrlKey) && !e.altKey && !e.shiftKey && e.key.toLowerCase() == 'k') {
const searchInput = document.querySelector('.search-bar-input')
if (searchInput) {

@FedOken FedOken Jun 11, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to use less nesting, I think it's easier to read something like this. At your discretion.

const hasModifier = e.metaKey || e.ctrlKey || e.altKey || e.shiftKey
if (hasModifier || e.key.toLowerCase() !== 'k') return

const searchInput = document.querySelector('.search-bar-input')
if (!searchInput) return

e.preventDefault()
searchInput.focus()

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to be more legible

@Randy808

Copy link
Copy Markdown
Collaborator Author

@FedOken The overly large trigger area is intended. See the behavior on blockstream.info. Maybe less necessary then, but now the hamburger icon is a lot smaller

@Randy808 Randy808 force-pushed the nav-update-20260609 branch from a7ca465 to 015b8f5 Compare June 12, 2026 15:37
@Randy808 Randy808 marked this pull request as ready for review June 12, 2026 15:38
@Randy808

Copy link
Copy Markdown
Collaborator Author

Last commit rebased and added margin to the top of the assets table

FedOken
FedOken previously approved these changes Jun 15, 2026
Comment thread client/src/views/search.js
Comment thread client/src/views/navbar.js Outdated
Comment thread flavors/blockstream/extras.css Outdated
@Randy808 Randy808 force-pushed the nav-update-20260609 branch from 07dac79 to 4ef129a Compare June 15, 2026 15:40
@EddieHouston EddieHouston self-requested a review June 16, 2026 05:56

@EddieHouston EddieHouston left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@Randy808 Randy808 merged commit 8be62b4 into Blockstream:master Jun 16, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants