SPLA-4322 - Sharing the constant analyzer between regular and test analyzers#981
Merged
Conversation
-Adding logic to support constant usages in test-only contexts (rhino mocks, for example)
omsmith
reviewed
Jul 16, 2026
| #region String tests | ||
| string variableStr = "This is a variable message"; | ||
| const string CONSTANT_STR = "This is a constant message"; | ||
| ConstantString constantStr = "This is a constant string message"; |
Contributor
There was a problem hiding this comment.
I think this is meaningless? D2L.Core doesn't exist in these tests
Contributor
Author
There was a problem hiding this comment.
Yeah, sorry, thought I had removed that in another commit, but the merge brought it back. A leftover from when I was exploring making the analyzer "understand" ConstantString. (It was a dumb idea)
omsmith
reviewed
Jul 16, 2026
omsmith
reviewed
Jul 16, 2026
Comment on lines
+30
to
+31
| <None Include="$(OutputPath)\$(AssemblyName).Rule.dll" Pack="true" PackagePath="analyzers/dotnet/cs" Visible="false" /> | ||
| <None Include="$(OutputPath)\$(AssemblyName).Rule.Constant.dll" Pack="true" PackagePath="analyzers/dotnet/cs" Visible="false" /> |
Contributor
There was a problem hiding this comment.
Suggested change
| <None Include="$(OutputPath)\$(AssemblyName).Rule.dll" Pack="true" PackagePath="analyzers/dotnet/cs" Visible="false" /> | |
| <None Include="$(OutputPath)\$(AssemblyName).Rule.Constant.dll" Pack="true" PackagePath="analyzers/dotnet/cs" Visible="false" /> | |
| <None Include="$(OutputPath)\$(AssemblyName).Rule.dll" Pack="true" PackagePath="analyzers/dotnet/cs" Visible="false" /> | |
| <None Include="$(OutputPath)\$(AssemblyName).Rule.Constant.dll" Pack="true" PackagePath="analyzers/dotnet/cs" Visible="false" /> |
omsmith
reviewed
Jul 16, 2026
Comment on lines
+29
to
+30
| <None Include="$(OutputPath)\D2L.CodeStyle.Analyzers.Rule.dll" Pack="true" PackagePath="analyzers/dotnet/cs" Visible="false" /> | ||
| <None Include="$(OutputPath)\D2L.CodeStyle.Analyzers.Rule.Constant.dll" Pack="true" PackagePath="analyzers/dotnet/cs" Visible="false" /> |
Contributor
There was a problem hiding this comment.
Suggested change
| <None Include="$(OutputPath)\D2L.CodeStyle.Analyzers.Rule.dll" Pack="true" PackagePath="analyzers/dotnet/cs" Visible="false" /> | |
| <None Include="$(OutputPath)\D2L.CodeStyle.Analyzers.Rule.Constant.dll" Pack="true" PackagePath="analyzers/dotnet/cs" Visible="false" /> | |
| <None Include="$(OutputPath)\D2L.CodeStyle.Analyzers.Rule.dll" Pack="true" PackagePath="analyzers/dotnet/cs" Visible="false" /> | |
| <None Include="$(OutputPath)\D2L.CodeStyle.Analyzers.Rule.Constant.dll" Pack="true" PackagePath="analyzers/dotnet/cs" Visible="false" /> |
omsmith
reviewed
Jul 16, 2026
Comment on lines
+52
to
+59
| <ItemGroup> | ||
| <ProjectReference Include="..\Rules\D2L.CodeStyle.Analyzers.Rule.Constant\D2L.CodeStyle.Analyzers.Rule.Constant\D2L.CodeStyle.Analyzers.Rule.Constant.csproj"> | ||
| <PrivateAssets>all</PrivateAssets> | ||
| </ProjectReference> | ||
| <ProjectReference Include="..\Rules\D2L.CodeStyle.Analyzers.Rule\D2L.CodeStyle.Analyzers.Rule\D2L.CodeStyle.Analyzers.Rule.csproj"> | ||
| <PrivateAssets>all</PrivateAssets> | ||
| </ProjectReference> | ||
| </ItemGroup> |
Contributor
There was a problem hiding this comment.
Suggested change
| <ItemGroup> | |
| <ProjectReference Include="..\Rules\D2L.CodeStyle.Analyzers.Rule.Constant\D2L.CodeStyle.Analyzers.Rule.Constant\D2L.CodeStyle.Analyzers.Rule.Constant.csproj"> | |
| <PrivateAssets>all</PrivateAssets> | |
| </ProjectReference> | |
| <ProjectReference Include="..\Rules\D2L.CodeStyle.Analyzers.Rule\D2L.CodeStyle.Analyzers.Rule\D2L.CodeStyle.Analyzers.Rule.csproj"> | |
| <PrivateAssets>all</PrivateAssets> | |
| </ProjectReference> | |
| </ItemGroup> | |
| <ItemGroup> | |
| <ProjectReference Include="..\Rules\D2L.CodeStyle.Analyzers.Rule.Constant\D2L.CodeStyle.Analyzers.Rule.Constant\D2L.CodeStyle.Analyzers.Rule.Constant.csproj"> | |
| <PrivateAssets>all</PrivateAssets> | |
| </ProjectReference> | |
| <ProjectReference Include="..\Rules\D2L.CodeStyle.Analyzers.Rule\D2L.CodeStyle.Analyzers.Rule\D2L.CodeStyle.Analyzers.Rule.csproj"> | |
| <PrivateAssets>all</PrivateAssets> | |
| </ProjectReference> | |
| </ItemGroup> |
omsmith
reviewed
Jul 16, 2026
Comment on lines
+136
to
+144
| // Argument is inside an expression tree (e.g. Moq Verify/Setup), so do nothing | ||
| if( IsInsideExpressionTree( argument ) ) { | ||
| return; | ||
| } | ||
|
|
||
| // Argument is a mock argument constraint (e.g. Arg<string>.Is.Anything), so do nothing | ||
| if( IsMockArgumentConstraint( argument.Value ) ) { | ||
| return; | ||
| } |
Contributor
There was a problem hiding this comment.
I was wondering if there was a way we could make this toggleable, like #if D2L_INCLUDE_TEST_CHECKS and pass that via <AdditionalProperties> in the ProjectReference, but I couldn't figure it out quickly (and may not work having two versions of the same DLL loaded into analyzers)
Contributor
There was a problem hiding this comment.
Could do it via AnalyzerOptions, but, follow-up-able
omsmith
reviewed
Jul 16, 2026
omsmith
left a comment
omsmith
left a comment
Contributor
There was a problem hiding this comment.
I maybe didn't catch all of the tabs-in-csproj. But between fixing those up, and the D2L.Core-in-tests, looks good
-Removing D2L.Core addition and ConstantString reference in spec tests
omsmith
reviewed
Jul 16, 2026
Contributor
There was a problem hiding this comment.
Suggested change
| <Version>0.224.0</Version> |
toddlang
changed the title
Contributor
Author
|
Compile is clear, FWIW |
omsmith
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-Adding logic to support constant usages in test-only contexts (rhino mocks, for example)