Repair issues in 'Reports' generation.#224
Open
henri62 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes:
Fix an exception in the code when an non-existing subindex is referenced in a TPDO. See Unhandled exception running "Reports->Network PDO". #222 for details and reproduction.
Fix an error when Reports->Documentation is called and you have spaces in your windows profile.
Tested with a file that has a mapping to a non-existing sub-index, it now reports this error in the generated report with a RED colored message (via a style sheet ref) that the subindex is missing. To my opinion no error pop-up or something is needed because the goal is to make a report, so it suits the purpose.
When you have a userprofile that contains spaces the generated temp file path for the *.md file also contains spaces and the viewer pop-up did not show up but gave an error of a missing file. The file is now quoted and the call is "modernized".
I have read the contributing guidelines, I agree to following them and I agree to the Developer's Certificate of Origin 1.1