IRSA-7801: Respect irsa_format when displaying floating-point values#58
Open
judith-ipac wants to merge 1 commit into
Open
IRSA-7801: Respect irsa_format when displaying floating-point values#58judith-ipac wants to merge 1 commit into
judith-ipac wants to merge 1 commit into
Conversation
judith-ipac
force-pushed
the
IRSA-7512_Gator_Support
branch
2 times, most recently
from
9749e11 to
49e2bf3
Compare
sreenivasapydi
approved these changes
Jun 8, 2026
sreenivasapydi
left a comment
sreenivasapydi
left a comment
There was a problem hiding this comment.
Look good to me, reviewed the code with a brief understand of the details in the IRSA-7693 and FormatPacket.hxx (comments are helpful) Ran the unit tests, all PASS.
Bonus: Retired obsolete non-Ascii_Writer version of write_type_as_ascii().
judith-ipac
force-pushed
the
IRSA-7512_Gator_Support
branch
from
4b59c93 to
46b05b6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bonus:
Retired obsolete non-Ascii_Writer version of write_type_as_ascii().