[ENG-11492] Improvements to shared search components and interfaces.#986
Open
nsemets wants to merge 6 commits into
Open
[ENG-11492] Improvements to shared search components and interfaces.#986nsemets wants to merge 6 commits into
nsemets wants to merge 6 commits into
Conversation
nsemets
changed the title
Contributor
|
@nsemets Could you make a jira ticket for this so we can track it? |
nsemets
changed the title
omar-cos
requested changes
Jun 26, 2026
| @for (step of steps(); track $index) { | ||
| @if (currentStep() === $index + 1) { | ||
| <div class="stepper" [ngStyle]="getStepPosition(step)"> | ||
| <div class="stepper" [ngStyle]="isTablet() ? step.position : step.mobilePosition"> |
There was a problem hiding this comment.
The old method returned step.mobilePosition || {} but the new template expression passes undefined directly to ngStyle when mobilePosition is absent. Change to step.mobilePosition ?? {} and add a test covering this case since the one that verified it was deleted.
Collaborator
Author
There was a problem hiding this comment.
SEARCH_TUTORIAL_STEPS always defines both positions. I made position and mobilePosition required on TutorialStep, so the compiler enforces this. The ?? {} fallback is no longer needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Improve code quality.
Summary of Changes