[ENG-11457] require at least 1 subject for draft and usual registrations#11786
Open
ihorsokhanexoft wants to merge 26 commits into
Open
[ENG-11457] require at least 1 subject for draft and usual registrations#11786ihorsokhanexoft wants to merge 26 commits into
ihorsokhanexoft wants to merge 26 commits into
Conversation
…NG-10768 * https://openscience.atlassian.net/browse/ENG-10768 ## Purpose When OSF undergoes planned downtime for software releases, users who are unaware of the maintenance window have no way of knowing the site is intentionally offline — they simply experience a broken site. A backend maintenance mode is needed so that when enabled, the API halts normal request processing and signals to clients that the system is in maintenance. ## Changes return 503 for API if maintanence_mode is set to true set maintenance mode via admin
… and selective existing templates (CenterForOpenScience#11698) * Add options to sync notification templates: restore one or all * Fix formatting of template name input in management commands
…nd improve template preview (CenterForOpenScience#11715) * Refactor notifications admin interface: add views, templates, and URLs for notifications management * Refactor notification rendering: enhance error handling and add mock data support in preview * Add JSON parsing error
…tionDetail' updates response (CenterForOpenScience#11719) * Add the 'id' and 'event_name' attributes to the 'SubscriptionDetail' updates response * Add assertions for 'id' and 'event_name' in subscription detail response test
…ce/develop Merge develop into feature/pbs-26-9
…tionDetail' updates response (CenterForOpenScience#11724)
…erge-develop [ENG-11259] Merge `develop` into `pbs-26-9` and fix migrations
…tivity logs (CenterForOpenScience#11697) * expose foreign_user in logs response; add missing logs for admin actions * fix tests * minor fixes; add tests
Conflicts not fixed in admin_tests/nodes/test_views.py
…erForOpenScience#11718) * fix check manual restart approval * minor fixes
…update digest email tasks (CenterForOpenScience#11764) * Add scheduled field to Notification model and update digest email tasks * Fix scheduled field handling in email tasks and update migration
sh-andriy
approved these changes
Jun 26, 2026
sh-andriy
left a comment
sh-andriy
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Validation's in the right spot (register + both set_subjects paths) and the relationship endpoint is replace-only so there's no DELETE bypass. Error maps to a clean 400. Approving.
Collaborator
|
@ihorsokhanexoft Please rebase onto |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
https://openscience.atlassian.net/browse/ENG-11457
Purpose
Draft registrations and usual registration should have at least 1 subject
Changes
Added validation