Move tests to GitHub actions#265
Open
kylegibson-rldatix wants to merge 25 commits into
Open
Conversation
…ine which ones work
…pypi with old pip
…n in py2 and py3
There was a problem hiding this comment.
Pull request overview
This PR introduces a GitHub Actions CI workflow intended to run the project’s test suite across multiple (including very old) Python versions, and adjusts the testing requirements to pin flake8.
Changes:
- Add
.github/workflows/ci.ymlto runnosetests --with-doctestin containerized Python environments (2.6–3.8). - Pin
flake8to a specific version inrequirements/testing.txt.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
requirements/testing.txt |
Pins flake8 in the testing dependency set. |
.github/workflows/ci.yml |
Adds a GitHub Actions workflow with “superlegacy” and “legacy” test jobs using Docker/container execution. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| coverage==3.6 | ||
| nose==1.3.0 | ||
| flake8 | ||
| flake8==3.3.0 |
Comment on lines
+72
to
+77
| - name: Install dependencies | ||
| run: pip install --requirement requirements/testing.txt | ||
| - name: Install PyDocX | ||
| run: pip install -e .[dev] # editable install so CLI entry points are available | ||
| - name: Run tests | ||
| run: nosetests --with-doctest |
Comment on lines
1
to
+4
| Jinja2>=2.0 | ||
| coverage==3.6 | ||
| nose==1.3.0 | ||
| flake8 | ||
| flake8==3.3.0 |
Comment on lines
+54
to
+61
| - python: "2.7" | ||
| image: python:2.7-slim | ||
| - python: "3.6" | ||
| image: python:3.6-slim | ||
| - python: "3.7" | ||
| image: python:3.7-slim | ||
| - python: "3.8" | ||
| image: python:3.8-slim |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.